From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Bob Halley Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix macOS 12 deprecation notices Date: Sat, 20 Aug 2016 16:15:35 -0700 Message-ID: <950B2310-61C7-4337-B799-67244B744BF4@play-bow.org> References: <315BE3C4-D984-470E-A4B4-20C8148FBA5A@play-bow.org> <20160818190422.GA23177@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3216\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1471746744 21852 195.159.176.226 (21 Aug 2016 02:32:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Aug 2016 02:32:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 21 04:32:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbIYe-0005SI-0s for ged-emacs-devel@m.gmane.org; Sun, 21 Aug 2016 04:32:20 +0200 Original-Received: from localhost ([::1]:35113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbIYb-00041p-0h for ged-emacs-devel@m.gmane.org; Sat, 20 Aug 2016 22:32:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbFUO-00052j-LA for emacs-devel@gnu.org; Sat, 20 Aug 2016 19:15:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbFUK-00013J-9f for emacs-devel@gnu.org; Sat, 20 Aug 2016 19:15:43 -0400 Original-Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:36243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbFUJ-00013B-Iy for emacs-devel@gnu.org; Sat, 20 Aug 2016 19:15:40 -0400 Original-Received: by mail-pf0-x231.google.com with SMTP id h186so20186848pfg.3 for ; Sat, 20 Aug 2016 16:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=play-bow.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6qzZqCh4IpHsAqCTeIwpn469RsEIGvt+DOMC+zb8VE4=; b=ZD/vEK/vn5hoX/fgcYemd0t5s/O7kzQMEY7eJkW9TCKcfqy4/rAYRVIG+xllwSLAB+ Mr+qwp+22iLSbhBWI6BbRl9abNhff2CU9OADp/LOeUp2y33F9TpnAy0/sIFH9LmU8Ym+ luBqNga1GW4zQ780U93JIi8mNTEfK/XVfQjxA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6qzZqCh4IpHsAqCTeIwpn469RsEIGvt+DOMC+zb8VE4=; b=juzduOlgoMhJk429OshPwF7pkys8FBtzrk1ty1WFsAl9rR7CbLd5j7eJdE9Z+7AfW6 2Pw+8rn04eD9mmVy0pFPPUTxrO5fH8su+mgDT9kC6zKYt9ZPbFZ8r09uS0D6vupRBSk9 JYgqw5sLSYLd3vw+5B/3jONB6hSRq6KFqEwBQq/A6UxmmrVt+Vf1glwjB995GvkbjlKI 9BCu1ES9ze+28QH9K6/08LTACUBgxhgbdTrj04mtO3PiUk+4jsunZw5Fca0I1woM0Psy DCTAFg5V3LKuLc1nkqQ/yV3cqEi/cIJh+gcdTfmeDG/iFxSZWTuSPiD/orw/XoyzGqat wGBA== X-Gm-Message-State: AEkoouvyfaetPQPQJ+wB2OJXfPmM1t0HSGhcvsbwC8ZsmR+ePTMnWnMKubASJrTq0FUTGg== X-Received: by 10.98.73.131 with SMTP id r3mr28029686pfi.112.1471734938108; Sat, 20 Aug 2016 16:15:38 -0700 (PDT) Original-Received: from [192.168.1.64] (162-206-76-144.lightspeed.sntcca.sbcglobal.net. [162.206.76.144]) by smtp.gmail.com with ESMTPSA id 15sm16424512pfz.36.2016.08.20.16.15.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Aug 2016 16:15:37 -0700 (PDT) In-Reply-To: <20160818190422.GA23177@breton.holly.idiocy.org> X-Mailer: Apple Mail (2.3216) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::231 X-Mailman-Approved-At: Sat, 20 Aug 2016 22:32:11 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206715 Archived-At: Yep, that removes most of them. Here's what's left: nsterm.m:6941:10: warning: null passed to a callee that requires a = non-null argument [-Wnonnull] [NSApp registerServicesMenuSendTypes: ns_send_types ^ For this one (above), my guess is to pass ns_return_types, which the = code creates but does not seem to use, but again I don't know enough to = be sure! nsterm.m:8475:52: warning: 'context' is deprecated: first deprecated in = macOS 10.12 - This method always returns nil. If you need access to the current drawing context, use [NSGraphicsContext = currentContext] inside of a draw operation. [-Wdeprecated-declarations] context: [e context] In the code making a "fake event" at nsterm.m:8470, it says that [e = context] is always nil. Probably just replacing this with nil is safe, = but I don't know enough to be sure. Otherwise I suppose you could just = call [e context] on older stuff, and say nil on 10.12 and later. =20 nsmenu.m:754:44: warning: 'context' is deprecated: first deprecated in = macOS 10.12 - This method always returns nil. If you need access to the current drawing context, use [NSGraphicsContext = currentContext] inside of a draw operation. [-Wdeprecated-declarations] context: [e context] ^ nsmenu.m:1535:62: warning: 'NSUtilityWindowMask' is deprecated: first = deprecated in macOS 10.12 [-Wdeprecated-declarations] aStyle =3D = NSWindowStyleMaskTitled|NSWindowStyleMaskClosable|NSUtilityWindowMask; = ^~~~~~~~~~~~~~~~~~~ = NSWindowStyleMaskUtilityWindow ^ nsmenu.m:1506:67: warning: conflicting parameter types in implementation = of 'initWithContentRect:styleMask:backing:defer:': 'NSWindowStyleMask' (aka 'enum NSWindowStyleMask') vs 'NSUInteger' = (aka 'unsigned long') [-Wmismatched-parameter-types] - initWithContentRect: (NSRect)contentRect styleMask: (NSUInteger)aStyle ~~~~~~~~~~ ^ 3 warnings generated. macfont.m:222:23: warning: implicit conversion from enumeration type = 'CTCharacterCollection' (aka 'enum CTCharacterCollection') to different enumeration type 'NSCharacterCollection' (aka 'enum = NSCharacterCollection') [-Wenum-conversion] collection:collection ^~~~~~~~~~ macfont.m:289:18: warning: 'setUsesScreenFonts:' is deprecated: first = deprecated in macOS 10.11 [-Wdeprecated-declarations] [layoutManager setUsesScreenFonts:YES]; ^ macfont.m:344:18: warning: 'setUsesScreenFonts:' is deprecated: first = deprecated in macOS 10.11 [-Wdeprecated-declarations] [layoutManager setUsesScreenFonts:screen_font_p]; ^ macfont.m:417:22: warning: = 'getGlyphsInRange:glyphs:characterIndexes:glyphInscriptions:elasticBits:bi= diLevels:' is deprecated: first deprecated in macOS 10.11 - Use = -getGlyphsInRange:glyphs:properties:characterIndexes:bidiLevels: instead [-Wdeprecated-declarations] [layoutManager getGlyphsInRange:(NSMakeRange (glyphIndex, 1)) ^ 4 warnings generated.