From: Bob Halley <halley@play-bow.org>
To: Alan Third <alan@idiocy.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix macOS 12 deprecation notices
Date: Sat, 20 Aug 2016 16:15:35 -0700 [thread overview]
Message-ID: <950B2310-61C7-4337-B799-67244B744BF4@play-bow.org> (raw)
In-Reply-To: <20160818190422.GA23177@breton.holly.idiocy.org>
Yep, that removes most of them. Here's what's left:
nsterm.m:6941:10: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
[NSApp registerServicesMenuSendTypes: ns_send_types
^
For this one (above), my guess is to pass ns_return_types, which the code creates but does not seem to use, but again I don't know enough to be sure!
nsterm.m:8475:52: warning: 'context' is deprecated: first deprecated in macOS 10.12 - This method always returns nil. If you
need access to the current drawing context, use [NSGraphicsContext currentContext] inside of a draw operation.
[-Wdeprecated-declarations]
context: [e context]
In the code making a "fake event" at nsterm.m:8470, it says that [e context] is always nil. Probably just replacing this with nil is safe, but I don't know enough to be sure. Otherwise I suppose you could just call [e context] on older stuff, and say nil on 10.12 and later.
nsmenu.m:754:44: warning: 'context' is deprecated: first deprecated in macOS 10.12 - This method always returns nil. If you
need access to the current drawing context, use [NSGraphicsContext currentContext] inside of a draw operation.
[-Wdeprecated-declarations]
context: [e context]
^
nsmenu.m:1535:62: warning: 'NSUtilityWindowMask' is deprecated: first deprecated in macOS 10.12 [-Wdeprecated-declarations]
aStyle = NSWindowStyleMaskTitled|NSWindowStyleMaskClosable|NSUtilityWindowMask;
^~~~~~~~~~~~~~~~~~~
NSWindowStyleMaskUtilityWindow
^
nsmenu.m:1506:67: warning: conflicting parameter types in implementation of 'initWithContentRect:styleMask:backing:defer:':
'NSWindowStyleMask' (aka 'enum NSWindowStyleMask') vs 'NSUInteger' (aka 'unsigned long') [-Wmismatched-parameter-types]
- initWithContentRect: (NSRect)contentRect styleMask: (NSUInteger)aStyle
~~~~~~~~~~ ^
3 warnings generated.
macfont.m:222:23: warning: implicit conversion from enumeration type 'CTCharacterCollection' (aka 'enum CTCharacterCollection')
to different enumeration type 'NSCharacterCollection' (aka 'enum NSCharacterCollection') [-Wenum-conversion]
collection:collection
^~~~~~~~~~
macfont.m:289:18: warning: 'setUsesScreenFonts:' is deprecated: first deprecated in macOS 10.11 [-Wdeprecated-declarations]
[layoutManager setUsesScreenFonts:YES];
^
macfont.m:344:18: warning: 'setUsesScreenFonts:' is deprecated: first deprecated in macOS 10.11 [-Wdeprecated-declarations]
[layoutManager setUsesScreenFonts:screen_font_p];
^
macfont.m:417:22: warning: 'getGlyphsInRange:glyphs:characterIndexes:glyphInscriptions:elasticBits:bidiLevels:' is deprecated:
first deprecated in macOS 10.11 - Use -getGlyphsInRange:glyphs:properties:characterIndexes:bidiLevels: instead
[-Wdeprecated-declarations]
[layoutManager getGlyphsInRange:(NSMakeRange (glyphIndex, 1))
^
4 warnings generated.
next prev parent reply other threads:[~2016-08-20 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <315BE3C4-D984-470E-A4B4-20C8148FBA5A@play-bow.org>
2016-08-08 20:04 ` FYI: Deprecations and Warnings for nsterm.m on Sierra Alan Third
2016-08-18 19:04 ` [PATCH] Fix macOS 12 deprecation notices Alan Third
2016-08-20 23:15 ` Bob Halley [this message]
2016-08-21 6:59 ` Kalle Olavi Niemitalo
2016-08-24 18:21 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=950B2310-61C7-4337-B799-67244B744BF4@play-bow.org \
--to=halley@play-bow.org \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).