unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: Drew Adams <drew.adams@oracle.com>, emacs-devel@gnu.org
Subject: Re: Should mode commands be idempotent?
Date: Mon, 25 Sep 2017 09:03:33 +0200	[thread overview]
Message-ID: <950166e7-2766-8a3e-1bc2-a93a356f652c@gmail.com> (raw)
In-Reply-To: <bcc96080-f2bd-422a-a574-ce00e5d66c3c@default>

On 2017-09-24 19:26, Drew Adams wrote:
>>> Has someone actually reported a problem that s?he ran into by
>>> encountering an actual mode function that was not idempotent?
>>
>> I think I mentioned visual-line-mode; the fact that it's not
>> idempotent is a concrete (though minor) problem for me.  I enable
>> it in a hook, and a major mode that I use enables it too.  Due to
>> the way visual-line-mode works, disabling it after this doesn't
>> restore my original settings.
> …
> That Emacs chooses to have its distributed modes be idempotent
> is one thing.  That some 3rd-party code might also mistakenly
> (unintentionally) prove to be non-idempotent is another, but
> similar thing.  Such cases represent things to fix.
>
> That is different from establishing a convention that
> modes should never, intentionally or unintentionally,
> be non-idempotent.

Yes, of course; you asked whether non-idempotence had ever been an issue for anyone; I gave you one example :)



  reply	other threads:[~2017-09-25  7:03 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 19:58 Should mode commands be idempotent? Philipp Stephani
2017-09-19 22:10 ` Clément Pit-Claudel
2017-09-19 22:29   ` Stefan Monnier
2017-09-20  7:24     ` Clément Pit-Claudel
2017-09-20 14:52       ` John Wiegley
2017-09-20 22:30         ` Stefan Monnier
2017-09-20 23:05           ` Drew Adams
2017-10-08 15:09         ` Philipp Stephani
2017-09-20 22:25       ` Stefan Monnier
2017-09-23  8:16         ` Clément Pit-Claudel
2017-09-23 14:17           ` Stefan Monnier
2017-09-23 20:37             ` Stefan Monnier
2017-09-19 22:58 ` Drew Adams
2017-09-20  3:10   ` Stefan Monnier
2017-09-20 17:52     ` Drew Adams
2017-09-21  1:11       ` Stefan Monnier
2017-09-21  5:22         ` Drew Adams
2017-09-21 18:28           ` Richard Stallman
     [not found]         ` <<9f11a3c6-b113-4bf6-9dab-f894b2ad77b5@default>
     [not found]           ` <<E1dv6D1-0006Jr-Fl@fencepost.gnu.org>
2017-09-22 15:54             ` Drew Adams
2017-09-23  0:39               ` Richard Stallman
2017-09-23  8:05               ` Clément Pit-Claudel
2017-09-24 17:26                 ` Drew Adams
2017-09-25  7:03                   ` Clément Pit-Claudel [this message]
2017-09-25 13:57                     ` Drew Adams
2017-09-26  0:36                       ` Stefan Monnier
2017-09-26  3:30                         ` John Wiegley
2017-09-26 17:55                           ` Drew Adams
2017-09-26 18:01                             ` John Wiegley
2017-09-26 18:50                               ` Drew Adams
2017-09-26 18:54                                 ` John Wiegley
2017-10-08 15:28                                   ` Philipp Stephani
2017-10-08 19:04                                     ` Stefan Monnier
2017-10-10  2:10                                       ` John Wiegley
2017-12-21 20:49                                       ` Philipp Stephani
2017-12-22  2:20                                         ` Stefan Monnier
2017-10-10 23:15                                   ` Herring, Davis
     [not found]               ` <<E1dvYUB-0007na-Mx@fencepost.gnu.org>
2017-09-24 17:26                 ` Drew Adams
2017-09-25 22:06                   ` Richard Stallman
2017-09-19 23:50 ` John Wiegley
2017-09-20  3:09   ` Stefan Monnier
2017-09-20 13:01 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=950166e7-2766-8a3e-1bc2-a93a356f652c@gmail.com \
    --to=cpitclaudel@gmail.com \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).