From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Clive Tovero Newsgroups: gmane.emacs.devel Subject: Re: Okay to commit purely cosmetic (indendation) fixes? Date: Sun, 9 Aug 2020 18:40:56 -0400 Message-ID: <94dd40a5-0195-b88b-3cc1-298d32f99ad8@aol.com> References: <94dd40a5-0195-b88b-3cc1-298d32f99ad8.ref@aol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34866"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 10 00:41:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4u0b-00090N-3V for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Aug 2020 00:41:41 +0200 Original-Received: from localhost ([::1]:60498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4u0a-00038X-60 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Aug 2020 18:41:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4u04-0002im-Jz for emacs-devel@gnu.org; Sun, 09 Aug 2020 18:41:08 -0400 Original-Received: from sonic314-21.consmr.mail.ne1.yahoo.com ([66.163.189.147]:35886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4u00-0004O4-JK for emacs-devel@gnu.org; Sun, 09 Aug 2020 18:41:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1597012861; bh=8eQVQ//ZTsB22KKFAcTrXjooj9J3cIWM7c+7UU/bO68=; h=To:From:Subject:Date:References:From:Subject; b=hGr1Bp1zZxRaDSHXUWfGU6k6m9/OWLI8OVEw9ohzi7lpPixTN5fbNwURnWDhiB8YEbpUkOWKDJiA4rVhaxhan22fTQJ1lmA1Aj0U1zgo1anRVgr7JCa1QT86yp7iYC2jK4LzfIoObFmjO6OlILnmu6K7/lVfXyj/RL+62/AP88/UKvPfRXwJv8ZFZBhAc4t3MFzIREbDaJGk8YCmScBVro4OcsZ11vyTkv/QaHKe8jHRpNng8Ym+oiNKj4HDPJfD1XMq2yarmz36wfbEGGf3mXijSWdTFY2SVNASQ9aFUqqb9P69CXgB56heuqUJs21NjA+Fho1abXhOX2xKqaRJ/w== X-YMail-OSG: SBeVi_kVM1klUBx3hzU4t4J6.wPTzQ3HniPVK8hjrQNyMnXc4AirADXU9o8JoAt _1G0xWG3x8uPRARPcCQfHaGY7_WI8Vm8JBXsuDjx90tGzpl.6WBKTObF9f7tpl43NxQvnNWGJxH7 .QfyAYmmV.oTy8fTyCW0ehJM6SaAjIG8HUFuS2apT7s0nXJ.ERvFk3ByGBZdfsYoL4l13N1W3DtU LjAL80NtgXYm1BJw7.WMY1oi_bFhUfcz3VhqNy6heyue.WNJRxy17xhWImpGBIz67e2CcsgZWTwJ h8mxnxOSIAvji4rEUMODC24vTD4Xlnpo_lyZtNyYFPoUd2Po5oWgYslvZmwXtqKUI4x0hXk8dmvj Enma5bgGmB7xUzkj6Hnq6h9DxYWQvHQ1QMNzcOvXUlcmsp27cRrGzZpER7EDDUflce.g8_lxgcmh _8hCxji0jwidggtN1rGaxGDUh2hgkib3vnV37BC7KxlMdv5lbbhlzVyS8a2ROYnDQjYSu1eIP9jK 9a59MFagh7IeNwt49QCdYhTWL7.dJ4boMp.qpLA6iZybkwrXRf6jg17VzFjs.5NCcd5DIX8LPQip .VXSqeaCnbpKsatbxQDjWsAEe_Vn51_jSw4z2SstHbwnc1A3fKXLnwXjR3XxatpeSdszi6r5EbD7 j4NRiHqtErxNmxenWZyHaRe5Jd1N8CYFDphZX1RkqpMnWQgFMiEXBuSLlguJRHdlCnWlgWnyCl0r JXImke8UVbKByt6P_QtWaGKHYIcV7sr3gbc1W0A9S3NVhgy0fjKh0OCDwgoWrl6VGIZd89dc36AM 1.ACwsioIiAxbqkfa_TmW8HjNLMmEgVk7.N3gL_RAz Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sun, 9 Aug 2020 22:41:01 +0000 Original-Received: by smtp419.mail.bf1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 1715b2bb5e37d85b74f62573a887aa3a; Sun, 09 Aug 2020 22:40:57 +0000 (UTC) Content-Language: en-US X-Mailer: WebService/1.1.16436 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=66.163.189.147; envelope-from=clive.tovero@aol.com; helo=sonic314-21.consmr.mail.ne1.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/09 18:41:01 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253567 Archived-At: Karl Foger: My comment would be that your subject line was enough detail. I personally wouldn't commit a tiny, syntactically insignificant, whitespace-only change. To each his own, but... Lars Ingebrigtsen: I don't understand why you wouldn't bundle whitespace changes, rather than one at a time, as long as they were to correct deviations from a coding standard. By the way, could you point us to the coding standard for Emacs that would would give us guidance?