Re: Treesit Regression In ec4d29c4494f32acf0ff7c5632a1d951d957f084

[Yuan Fu <casouri@gmail.com>]

> On Sep 9, 2023, at 10:26 PM, Yuan Fu <casouri@gmail.com> wrote:
> 
> 
> 
>> On Sep 9, 2023, at 9:00 PM, Danny Freeman <danny@dfreeman.email> wrote:
>> 
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>>> 
>>> Hmmm, I can’t reproduce this. I’m getting
>>> 
>>> Matched rule: ((parent-is "source") parent-bol 0)
>>> Matched rule: (clojure-ts--match-expression-in-body parent 2)
>>> 
>>> The commit you pointed to does change treesit-node-parent, so it does match with parent-is matcher not working.
>>> 
>>> Might be because I recently upgraded to a newer tree-sitter library. If you compile with the newest tree-sitter build (from their repo), do you still see this problem?
>> 
>> Before I was just using whatever tree-sitter version my distro packages.
>> Apparently v0.20.8 (built from the git tag of the same name)
>> 
>> I tried compiling with this version
>> https://github.com/tree-sitter/tree-sitter/commit/524bf7e2c664d4a5dbd0c20d4d10f1e58f99e8ce
>> 
>> which at the time of writing is the latest, and still experience the
>> same problem. I also made sure to re-compile my grammars.
>> 
>> I may have done something wrong though when building. I'm
>> going to try to build using a more traditional process rather than with
>> nix and see if that helps.
>> 
>> Thank you,
>> -- 
>> Danny Freeman
> 
> I take that back. It is indeed caused by that commit. I just had a wrong Emacs build when testing. In that commit, ts_tree_cursor_goto_first_child_for_byte seem to be the problem.
> 
> Yuan

What I found is that, for some reason, ts_tree_cursor_goto_first_child_for_byte doesn’t always work as expected in clojure [1]. In your example, if I evaluate (treesit-node-parent (treesit-node-at (point))) with point at the beginning of  “defn”, “foo”, “[]”, and “1”, only “defn” correctly evaluates to the parent node. I tried this in other modes like c-ts-mode, but things seems to work fine in all the few cases I tried.

So now the question is, is there anything tree-sitter-clojure does differently? Not saying it does, but that seems like a starting point.

[1] Instead of returning the first child node of NODE that extends beyond POS, ts_tree_cursor_goto_first_child_for_byte (NODE, POS) returns false (meaning not found).

Yuan