From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: activities Date: Fri, 26 Jan 2024 04:48:51 -0600 Message-ID: <944e8248-e846-42df-b4c7-4dbdc6c8a7ed@alphapapa.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29073"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: adam@alphapapa.net, emacs-devel@gnu.org To: me@eshelyaron.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 26 11:49:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTJmS-0007Ip-GL for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Jan 2024 11:49:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTJlc-0003hX-5T; Fri, 26 Jan 2024 05:49:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTJlb-0003hO-0h for emacs-devel@gnu.org; Fri, 26 Jan 2024 05:48:59 -0500 Original-Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTJlZ-0005XY-8K for emacs-devel@gnu.org; Fri, 26 Jan 2024 05:48:58 -0500 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DEF2010390B; Fri, 26 Jan 2024 10:48:53 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a312.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 86AAC1038DC; Fri, 26 Jan 2024 10:48:53 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1706266133; a=rsa-sha256; cv=none; b=eZKnHwk7DQN1DxuYS7VI6SK8cJDskCe7jaToBAu6LOdjnL1lcEv2YtuOnjz99UMVCr5qdz 3xs89VBd97L2ZMjM0eTIDNXOBlVit1ZUEp2s1lb8YnCyGfAt9YdAh69oz1SbSHBCis4qt+ Uwpz62qh+D7Yy4waWAq21tCoR4+Lxs+tM6923lEFoGElVzBl5GohAnr+lSi6kjoH0B51dF Drv1sxBmnMzFc379O7b0PpxVkbIPOGP01AqZgJFpV9ZMP/I2jdnErJzQu5SS0B69IqOVV0 kc/P/l+k6zokdpY7rAgSbcjAjcgjXV2eHeHuljFXl3jEKN/GwV5MgTDCHRIZfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1706266133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rr/WFlVmM4Dn9mdmcecwjBu+OqkTngheTW+21gOEj3I=; b=FBZn45fHqRNhfnPTkY2QQDluXaK9XTmLPc3alvFxtbnvATP1y8gKXd0YR5M/n7cJy4EhVp HoyvuSeW2uDLQZC9DJIbKHJlYcrwoHwOBar7mimzIwumiO5fdjQkXaLlIvTewsSMauuli2 O9SRDjm5vyMgho5QtokRRcG8zKcs3M6ZeNhmhR+nxYTulYDmvGtXIl4f/MPzYKr/vfh5+1 EZ9iSmTFxN7YfgKkhXfcyaR307o6Cvn6CcutWrpC1cwdRi334DBAxbcLSdw4ca4b+hG5Ha 9nQlwQOdwSDffV+otnVPj2UI3uHWKIjtSwzOIv46vT4myJMRE2XSvrr6bVvhBw== ARC-Authentication-Results: i=1; rspamd-9c9494d96-9f68b; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Irritate-Trade: 77db119c6473e676_1706266133792_3762422125 X-MC-Loop-Signature: 1706266133792:3214882368 X-MC-Ingress-Time: 1706266133792 Original-Received: from pdx1-sub0-mail-a312.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.126.230.203 (trex/6.9.2); Fri, 26 Jan 2024 10:48:53 +0000 Original-Received: from [10.66.0.30] (unknown [91.193.232.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a312.dreamhost.com (Postfix) with ESMTPSA id 4TLvZD65KszGy; Fri, 26 Jan 2024 02:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1706266133; bh=Rr/WFlVmM4Dn9mdmcecwjBu+OqkTngheTW+21gOEj3I=; h=Date:To:Cc:Subject:From:Content-Type:Content-Transfer-Encoding; b=GMJPO3l4yEdLSSjlI8+CJPCWcClIQ5rUSBUnLhdlMluYWFEZ3jEucMoAVgiet1Jxl KWgY84Kz7nPsw7OgiiXcSnqtk7CziSCzqh2ld6r+W7L+Vly455tPV1M1z09Y47RbWp 4oy+TjR4xnl+cwbb5JICxOws7IGlqBBt8G3eQriOsapXdqUY9w5a2SnK+R9nW2lrO6 w6hU89micMWiL+cBnJ8hNlzBOfxuctoAKMgBQxG08dv6ilWnjH0x+M0fxglprtz0IT xQ1NyN14Kj/U1wnCNfjuZCsuwzFtoXHDAbdhA9nMfIiaVIb33+Uvckos/SpV1uEzFr o0yRcvychOcTw== Content-Language: en-US In-Reply-To: Received-SPF: neutral client-ip=23.83.209.24; envelope-from=adam@alphapapa.net; helo=buffalo.birch.relay.mailchannels.net X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315426 Archived-At: Hi Eshel, > FWIW, I think a spot a small mistake in `activities-completing-read`: > passing the value of the history variable to `completing-read` instead > of the variable name. Also, it seems like the commands that use this > function expect an existing "activity", so would it make sense to accept > only matching inputs? That is, making the following change: Thanks for catching those. I pushed a fix and mentioned you in the commit message. --Adam