From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Fri, 09 Apr 2021 11:27:41 +0000 Message-ID: <940751cee5d04ecbbca3@heytings.org> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <878s5wmsjp.fsf@mail.linkov.net> <87mtubz4ls.fsf@mail.linkov.net> <8735w22s9b.fsf@mail.linkov.net> <3ec7e2e58a3733a48ae9@heytings.org> <878s5tc0rn.fsf@mail.linkov.net> <3ec7e2e58a49d4f0ec99@heytings.org> <878s5t9p1i.fsf@mail.linkov.net> <9ff81b52fad2911cc740@heytings.org> <87im4w1tgw.fsf@mail.linkov.net> <9ff81b52fa878cb35a86@heytings.org> <87pmz4zgn5.fsf@mail.linkov.net> <9ff81b52fa72c1233122@heytings.org> <83czv47z99.fsf@gnu.org> <940751cee5bc247768d3@heytings.org> <837dlb91mk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9841"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spacibba@aol.com, emacs-devel@gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 09 13:28:44 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUpJc-0002Qg-Gx for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 13:28:44 +0200 Original-Received: from localhost ([::1]:57790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUpJb-0000qk-IW for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 07:28:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUpIg-0000He-Kx for emacs-devel@gnu.org; Fri, 09 Apr 2021 07:27:46 -0400 Original-Received: from heytings.org ([95.142.160.155]:35268) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUpIe-00031O-Q9; Fri, 09 Apr 2021 07:27:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617967662; bh=FIvzpxGzXpWc27YWBEWJA2+56jZcIjI4mF3e+TBu0Jg=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=aYUUA2aoBCDIOFm02j1pucXtumfYQfrNSSyXIKFukR/29WQ0T5kr++W1XXLPxBKPN 4Djp+idGx+M2eDGrBnitqE+l4/2i82K8H9XRppPsFt2SKMykBowPiygECSqUuLYAp9 O6k5FZr6DQnlTYXkyMmcu2uPxdTMf1hZIbhJepgHwpQYRIZ6DNpPfrt787bTawykgg KFi54cW+J0rQlEI4hKgdMHWMhV7p+6XtGs1GWQTDPFtJSCTP1D9qdfrzNWXYFUf726 eRqJlITJsAjzPjbS70CLSoIKcYpk77r/3CJYiWl/2o1Q+nhfXQDRQ5RUI0fgcP6aHc Bx4frP3fP+UGw== In-Reply-To: <837dlb91mk.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267707 Archived-At: >> I tend to agree with you, but I'm not sure. There is already an >> 'isearch-allow-scroll' and its corresponding 'isearch-scroll' property, >> which changes the behavior of motion commands: it becomes possible to >> scroll (recenter, scroll-up, scroll-down, ...) but without changing the >> current match. This patch does something related, but different: it >> becomes possible to scroll among the matches. > > The "scroll" part is what I think needs to be amended: the commands you > are affecting are not scroll commands, they are cursor motion commands. > Okay, so what you mean by "scroll" in this context is "change the visible portion of the buffer without moving the cursor". I think I understand your point, even though that's not what scroll-up-command and scroll-down-command do. Would "isearch-allow-motion" and the property "isearch-motion" be okay? > > I don't understand: why are you wrapping the call with condition-case, > in that case? > It's not necessary (but AFAIU it's harmless) for the four commands that are enabled by isearch-allow-motion, it is also not necessary for: (put 'next-line 'isearch-match-scroll '(next-line . forward)) which will correctly wrap at EOB, but it necessary for: (put 'previous-line 'isearch-match-scroll '(previous-line . backward)) For some reason, in this case if the error is not catched, Isearch does not wrap at BOB, but instead enters in a strange state where you can move the cursor around. This might be a bug that should be corrected instead of circumventing it by catching the error.