From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Fri, 09 Apr 2021 14:36:53 +0000 Message-ID: <940751cee50d69f2231d@heytings.org> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <878s5wmsjp.fsf@mail.linkov.net> <87mtubz4ls.fsf@mail.linkov.net> <8735w22s9b.fsf@mail.linkov.net> <3ec7e2e58a3733a48ae9@heytings.org> <878s5tc0rn.fsf@mail.linkov.net> <3ec7e2e58a49d4f0ec99@heytings.org> <878s5t9p1i.fsf@mail.linkov.net> <9ff81b52fad2911cc740@heytings.org> <87im4w1tgw.fsf@mail.linkov.net> <9ff81b52fa878cb35a86@heytings.org> <87pmz4zgn5.fsf@mail.linkov.net> <83eefk802u.fsf@gnu.org> <871rbjdea4.fsf@mail.linkov.net> <8335vz91en.fsf@gnu.org> <940751cee594ef1cf8a4@heytings.org> <83zgy77hep.fsf@gnu.org> <940751cee566285b8519@heytings.org> <83wntb7eli.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11058"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spacibba@aol.com, juri@linkov.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 09 16:38:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUsH4-0002jY-S5 for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 16:38:18 +0200 Original-Received: from localhost ([::1]:37004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUsH2-0002vz-NI for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 10:38:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUsFp-00026B-2B for emacs-devel@gnu.org; Fri, 09 Apr 2021 10:37:01 -0400 Original-Received: from heytings.org ([95.142.160.155]:35488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUsFk-0004dY-Hl; Fri, 09 Apr 2021 10:37:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617979013; bh=+LV5qcgrfvFOG4EEpWq24DOCUPYjnjACf4JUjMSfSTE=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=E5JmKIAIL2atTYGZVYp+tjll33JWpU6rKDWbzKHYW1UU5t5eMNIW70WA453OCnuNm p73kgR/CD2xJJMrPIcrNMRz8ZO8uWY6K8yebfnS2HOTDP0rUT1iTEowqca3K8+hGtL IkFomo/LwOLqiCl/3xGHYKmD7xlUQjCoJxoY9QQTnEeZGJQ3V10dJm3OYMGw/AJksr 9r54xeHluOTlApNj69O2vDe2THIZgLE3b7jArllPOjnOCDLbPleUfJmRee04iamjXQ tWh81wtC0+h1fzHqrJldxMFWXSdDmmktT3Faa5CLA2xrzOrIIbAH+sRHxx+daGTGkU wVhSXXor2c58A== In-Reply-To: <83wntb7eli.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267720 Archived-At: >>> The issue is whether we need to change the direction as a side effect >>> of isearch-beginning-of-buffer. From my POV, this is unexpected. The >>> direction should stay what it was before. >> >> Yes, I understand the issue, but disagree that it is unexpected. Just >> try it, replace: >> >> (isearch-repeat 'forward arg))) >> >> by: >> >> (isearch-repeat (if isearch-forward 'forward 'backward) arg))) >> >> in isearch-beginning-of-buffer, type C-r isearch M-s M-<, and you'll >> see that on the contrary not changing the direction is unexpected, that >> behavior can only be considered as a bug. > > Why do you consider that behavior a bug? If the user wants to change > the direction, he/she can do that any time. > Did you actually try it? With the code above, in the center of isearch.el, this is what is happening: C-s isearch : you are searching forward M-s M-> : you want to see the last occurrence (which corresponds to your search direction : forward), yet it says "Failing I-search" M-s M-> : you are now on the first line of isearch.el M-s M-> : "Failing wrapped I-search" C-r isearch : you are searching backward M-s M-< : you want to see the first occurrence (which corresponds to your search direction : backward), yet it says "Failing I-search backward" M-s M-< : you are now on the last line of isearch.el M-s M-< : "Failing wrapped I-search backward" How on earth could such a behavior be considered a feature?