From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 68ae6fa: Improved light/dark colour predicate (bug#41544) Date: Fri, 12 Jun 2020 17:50:32 +0200 Message-ID: <93F81C41-E774-4C02-9E9D-5B2CD1F66445@acm.org> References: <20200610181238.9796.44750@vcs0.savannah.gnu.org> <20200610181239.947C4204DF@vcs0.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_EB755992-E2FD-40AE-B803-404CDFE8B466" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="19586"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Emacs developers To: Yuri Khan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 12 17:51:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjlxm-000546-FE for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Jun 2020 17:51:26 +0200 Original-Received: from localhost ([::1]:53650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjlxl-0001yX-Bx for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Jun 2020 11:51:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjlx5-0001Rn-FV for emacs-devel@gnu.org; Fri, 12 Jun 2020 11:50:43 -0400 Original-Received: from mail150c50.megamailservers.eu ([91.136.10.160]:40694 helo=mail50c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjlx3-0005Qg-3Z for emacs-devel@gnu.org; Fri, 12 Jun 2020 11:50:43 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1591977036; bh=/PEP4X/p6yNOKAElznj2K6D4LHhBfi+vR1PGE55nVn0=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=M6KoZMX/fdhnaWy+R1bLG5D/1EKpQBHQ9I0/HcBlpimgD4pZCNQC5Flkx7rXbh79W CVZ3Wyqmvn468Zz8dZ1bv/+215qh5RONSJKmKL4h4OW99aNIKl0U+kcCmRDSIXY+VP 4LgApJeg6xd1URuUm3G69a62FgOp1o5ttkQfH7aw= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 05CFoWAe025785; Fri, 12 Jun 2020 15:50:34 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F1B.5EE3A3C6.003C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NoevjPVJ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=pGLkceISAAAA:8 a=I8twSn5vt4Fg28AA-OYA:9 a=CjuIK1q_8ugA:10 a=XRvUXlFVGjt75wj9k9sA:9 a=1OfwrDeanrQA:10 Received-SPF: softfail client-ip=91.136.10.160; envelope-from=mattiase@acm.org; helo=mail50c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/12 11:50:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252134 Archived-At: --Apple-Mail=_EB755992-E2FD-40AE-B803-404CDFE8B466 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 11 juni 2020 kl. 21.22 skrev Yuri Khan : > My equipment [...] says that shade of gold in fact > performs okay in all four scenarios I have no reason to doubt your observations. Let's try a plebiscite! * * * Dear Emacs developer or user, Please load the attached code (any Emacs version), and run M-x = contrast-compare with various cutoff values on your favourite system, to = find what value is best for readability of the colour names (first = column). Colours with luminance (last column) below the cutoff will be use white = text, others black. It is mainly Emacs in graphical (non-TTY) mode that = is of interest. Please reply (to emacs-devel or to me) the following pieces of = information: * the cutoff value you found optimal * system information: window system, screen, anything you think is = relevant * whether you use a light or dark background in your Emacs --Apple-Mail=_EB755992-E2FD-40AE-B803-404CDFE8B466 Content-Disposition: attachment; filename=color-contrast.el Content-Type: application/octet-stream; x-unix-mode=0644; name="color-contrast.el" Content-Transfer-Encoding: 7bit ;;; -*- lexical-binding: t -*- (defconst contrast-default-cutoff 0.325) (defun contrast-compare (cutoff) "Compare black and white text on various colours." (interactive (list (string-to-number (read-from-minibuffer "Cutoff value: " (number-to-string contrast-default-cutoff))))) (with-current-buffer (get-buffer-create "*Contrast comparison*") (erase-buffer) (let ((cols nil) (seen (make-hash-table :test 'equal))) (dolist (name (defined-colors)) (let ((cv (color-values name))) (unless (gethash cv seen) (puthash cv cv seen) (push (cons cv name) cols)))) (insert (format "cutoff = %f\n" cutoff)) (dolist (c (reverse cols)) (let* ((cv (car c)) (name (cdr c)) (hex (apply #'format "#%02x%02x%02x" (mapcar (lambda (x) (/ x 256)) cv))) (rgb (mapcar (lambda (x) (/ x 65535.0)) cv)) (r (expt (nth 0 rgb) 2.2)) (g (expt (nth 1 rgb) 2.2)) (b (expt (nth 2 rgb) 2.2)) (y (+ (* r 0.2126) (* g 0.7152) (* b 0.0722))) (fg (if (< y cutoff) "#ffffff" "#000000"))) (insert (propertize (format " %-20.20s " name) 'face (list :background name :foreground fg)) (propertize (format " %s " hex) 'face (list :background name :foreground "#ffffff")) (propertize (format " %s " hex) 'face (list :background name :foreground "#000000")) (format " %.5f\n" y))))) (let ((pop-up-windows t)) (display-buffer (current-buffer))))) --Apple-Mail=_EB755992-E2FD-40AE-B803-404CDFE8B466--