unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.
Date: Tue, 26 Oct 2021 12:35:41 +0300	[thread overview]
Message-ID: <936d9d26-4d94-53db-bb77-7463b8147864@yandex.ru> (raw)
In-Reply-To: <9806D073-4E56-4616-9C94-3F45513E5FE7@acm.org>

On 26.10.2021 11:56, Mattias Engdegård wrote:
> It felt small-minded to generate obsoletion warnings for external packages that now have to make their code uglier in order to avoid that if they are particulate about a clean CI, especially if they compile with byte-compile-error-on-warn (which I often do).
> 
> The warning doesn't tell them anything useful; the semantics haven't changed. This is in contrast to the variables made obsolete.
> 
> Does this reasoning make sense? I could revert the change.

I don't have a strong opinion about it, but that's how we usually do 
renames: without changing semantics, mark the previous name as obsolete.

I suppose the alternative is to wait for ~6 years until it's reasonable 
to drop support for Emacs 28 in third-party code? And then mark it obsolete?



  reply	other threads:[~2021-10-26  9:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211026081718.30075.27468@vcs0.savannah.gnu.org>
     [not found] ` <20211026081719.E1D3721011@vcs0.savannah.gnu.org>
2021-10-26  8:48   ` master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete Dmitry Gutov
2021-10-26  8:56     ` Mattias Engdegård
2021-10-26  9:35       ` Dmitry Gutov [this message]
2021-10-26 18:12         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=936d9d26-4d94-53db-bb77-7463b8147864@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).