From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Harald_J=c3=b6rg?= Newsgroups: gmane.emacs.devel Subject: Perl and Emacs: Developing tests for progmodes Date: Thu, 3 Sep 2020 15:42:47 +0200 Message-ID: <935d77f8-72c4-16fd-f9d6-39ba965e99e8@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24248"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 Cc: Stefan Kangas , Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 03 15:43:27 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDpWR-0006CH-MU for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Sep 2020 15:43:27 +0200 Original-Received: from localhost ([::1]:45730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDpWQ-0006y0-NH for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Sep 2020 09:43:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDpVu-0006TU-No for emacs-devel@gnu.org; Thu, 03 Sep 2020 09:42:54 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:34525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDpVs-0000rd-F5 for emacs-devel@gnu.org; Thu, 03 Sep 2020 09:42:54 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 19E5516005F for ; Thu, 3 Sep 2020 15:42:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1599140569; bh=g9oJ3JHLRDKGWzBskWRenJFa6ZSt2ZUAeyIaJIhwjiQ=; h=To:Cc:From:Subject:Autocrypt:Date:From; b=LbIzYMmcYiyA5FToPpq26xO/hTh9oqpoNqaOILPcfm4tOdGB2MxBFySX0N5dGQ0av VcEVrr9REy+8wrcZBRjhQYyZg1L1Gsl1r63McslyalOCbz7kkkLe/VazPPE2sobx0+ NhAkCVtbt5RCWgKEmdlhn+hk47JY7yogSgwuDL8eUpvt14C0OaEEMcJz8e+nRviB8w d62bgE17lBU7yeaErEjT/vvcYSS/ZHm0dltkACK54h8QIVZRY5sDWUyLsRpkcpCZ7E VDd0a6/Z2CcbhwA2rvUqWJtAott/Fn+63TrAioBn2/yQPzlC+okxxIzSaSXGeQxUS9 E5IA9N52KaRRA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Bj27D30cCz6tmS; Thu, 3 Sep 2020 15:42:48 +0200 (CEST) Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN Content-Language: en-US Received-SPF: pass client-ip=185.67.36.65; envelope-from=haj@posteo.de; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 06:27:49 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254494 Archived-At: Hi emacs-devel, Emacs comes with two modes to edit Perl sources: the rather lightweight perl-mode, and the not-so-lightweight cperl-mode. Two weeks ago I wrote a first ERT test for a bug fix in cperl-mode in test/lisp/progmodes/cperl-mode-tests.el. This test has been rewritten so that it can be applied to both cperl-mode and perl-mode, which is nice. However, there are bugs in cperl-mode which perl-mode doesn't have, mostly because perl-mode doesn't offer the functions which fail in the first place. So, tests for these bugs need to (require 'cperl-mode), and they make no sense when testing perl-mode. I expect most of the upcoming tests to fall into that category. To solve this, we could: - Split the tests into two and manually copy over tests where this makes sense or: - Split the tests into a "common" set plus two sets for the specific modes (how would the files be named in that case?) or: - Keep all tests in one file and tag the individual tests. Are there any similar cases in the set of Emacs packages, or conventions how to do it? -- Cheers, haj