unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Harald Jörg" <haj@posteo.de>
To: emacs-devel@gnu.org
Cc: Stefan Kangas <stefankangas@gmail.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Perl and Emacs: Developing tests for progmodes
Date: Thu, 3 Sep 2020 15:42:47 +0200	[thread overview]
Message-ID: <935d77f8-72c4-16fd-f9d6-39ba965e99e8@posteo.de> (raw)

Hi emacs-devel,

Emacs comes with two modes to edit Perl sources: the rather
lightweight perl-mode, and the not-so-lightweight cperl-mode. Two
weeks ago I wrote a first ERT test for a bug fix in cperl-mode in
test/lisp/progmodes/cperl-mode-tests.el.

This test has been rewritten so that it can be applied to both
cperl-mode and perl-mode, which is nice.

However, there are bugs in cperl-mode which perl-mode doesn't have,
mostly because perl-mode doesn't offer the functions which fail in the
first place.  So, tests for these bugs need to (require 'cperl-mode),
and they make no sense when testing perl-mode.  I expect most of the
upcoming tests to fall into that category.

To solve this, we could:

 - Split the tests into two and manually copy over tests where this
   makes sense or:

 - Split the tests into a "common" set plus two sets for the specific
   modes (how would the files be named in that case?) or:

 - Keep all tests in one file and tag the individual tests.

Are there any similar cases in the set of Emacs packages, or
conventions how to do it?
-- 
Cheers,
haj



             reply	other threads:[~2020-09-03 13:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 13:42 Harald Jörg [this message]
2020-09-03 15:52 ` Perl and Emacs: Developing tests for progmodes Stefan Monnier
2020-09-03 20:17   ` Stefan Kangas
2020-10-22 13:42     ` Stefan Kangas
2020-10-22 15:28       ` Stefan Monnier
2020-10-22 16:32         ` Stefan Kangas
2020-10-22 16:30       ` Harald Jörg
2020-10-22 19:38         ` Stefan Kangas
2020-09-03 17:34 ` Eli Zaretskii
2020-09-03 20:00   ` Harald Jörg
2020-09-04  6:55     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=935d77f8-72c4-16fd-f9d6-39ba965e99e8@posteo.de \
    --to=haj@posteo.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).