From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: last_marked array is now ifdef'ed away Date: Tue, 17 Sep 2024 12:15:16 +0200 Message-ID: <9354266E-9F9E-430E-A862-2169A62C9F67@gmail.com> References: <86zfokyp64.fsf@gnu.org> <86ed5pkz53.fsf@gnu.org> <851C7C12-44A1-4661-9EA7-16B0B7209D11@gmail.com> <86a5gbk295.fsf@gnu.org> <8634m2f8ii.fsf@gnu.org> <86o74pea7k.fsf@gnu.org> <861q1ldmla.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12513"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Andrea Corallo To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 17 12:15:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqVFW-00034A-Je for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Sep 2024 12:15:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVF3-0004sq-Uw; Tue, 17 Sep 2024 06:15:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVEy-0004sI-2K for emacs-devel@gnu.org; Tue, 17 Sep 2024 06:15:28 -0400 Original-Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqVEw-0003dr-4v; Tue, 17 Sep 2024 06:15:23 -0400 Original-Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-53568ffc525so6341224e87.0; Tue, 17 Sep 2024 03:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726568118; x=1727172918; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=nwOQ7TE2o27wUr9LuNazgxnnGA8h6eh4Z3EqoVoMHCo=; b=k63C/YsdB7UIweXaBj9owHW7httY6UJ7YLR8sqFq72bloh6FhXlM/aR3NGaXo/crhl 4mA4DnCOCPYazaGfOMhO6rZkgo329pqsZMOZ2sf6VFAAr/rsjYhp4T+qUQQSxcZesWHa W21jVp1aF47H4Beil2muxnkxWd58TJbooHtFhvlP1QcZ6Kh4dyMSKgEzt0AYu6+lF58w B7CSwANQUuAAiTsRpPMOpanw50KUqcZyLcH9f2v9t2+jwtcIeEnKtIg5Uq+Wm0/bMV0l Bg4XuP7zXjiTswEO8+XTdVuNAZGb9ucqmUMYbl/T18tKjTiPzEK/krYJ4xr09iThrBJe 2ZYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726568118; x=1727172918; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nwOQ7TE2o27wUr9LuNazgxnnGA8h6eh4Z3EqoVoMHCo=; b=sK1QFcEjlix5scO+lmk2LZE3VDmNJbhf3NjId5QF7UYCzb647fC8o/uQRZrOjKyj63 B/3tVW7g9fUWZ64OhukYovMj89nQa5ehLAjzRm/wymv854AVUPuAsZCn89ehw2H8VSOo bUu7mXGwM0z0b+q1lPXrEM/1d48KNhZ8GAPn8LeoReQLmdqHR08Y6MsTS1JlBfK6JFuz yqQtIkfd1dUpaWt49s3fbLYLPwEdF+Aiba+djwnUdgDUbKcjBbJYmNrBBZpOjK7+sevg u9xmEaDDwYc4AHSDc2x6LqlmCWz9wIaV6+ohc7zVweQbuy8JylXRiKi17XxN8J0Ec3xP wlvw== X-Forwarded-Encrypted: i=1; AJvYcCVmSLRbbniR5mpBt39zqqY+HBhRfu0gaPlYUd0JWzH6iHuzqdLwclhAjM+lo+Qp917zXdaUj4r60w==@gnu.org X-Gm-Message-State: AOJu0YxzwLPelH2N8BR91jWRZlj1qGlzLHkuCjNtWS+UxnQTPkvwzsLp zV7XbWrSRpRmTsuxMdX882K3FUE1gtYGnnZ4nKJM6nCQh9jzbPitnWpngw== X-Google-Smtp-Source: AGHT+IFTMPd3w87cR7qHUWMZJXdXxWg4q095ssB7Bhfhtbm6/uv2Cs5BxdOxqBuNwdZB2mRHLwR1mg== X-Received: by 2002:a05:6512:3e04:b0:52e:a68a:6076 with SMTP id 2adb3069b0e04-53678ff2e04mr8567517e87.49.1726568118073; Tue, 17 Sep 2024 03:15:18 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-536870c57e8sm1151303e87.309.2024.09.17.03.15.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2024 03:15:17 -0700 (PDT) In-Reply-To: <861q1ldmla.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323685 Archived-At: 15 sep. 2024 kl. 16.21 skrev Eli Zaretskii : > There's no need for any evidence to keep the code which we always had. Well, we didn't have it in Emacs 29, so one might be excused for = thinking it wasn't a strict necessity. > That won't help because GC crashes are seldom if ever reproducible. > So if the trace is off, the information is gone and cannot be > recovered in practice. My experience is rather that in such cases the crash was already gone = because there was no core dump or debugger attached anyway, but we then = take the necessary steps to catch the bug next time =E2=80=93 turn on = core dumps (if possible), run with a debugger, enable checking, etc =E2=80= =93 and we always end up trapping the gremlin eventually. Anyway, I'm going to re-enable the mark trace buffer for the sake of = development peace; since it's important to you, that's also worth = something. I shall add a configuration option for disabling it, with its = trade-off clearly documented, so that users can make an informed = decision, but the buffer will be enabled by default. 16 sep. 2024 kl. 20.07 skrev Andrea Corallo : > 5% slowdown during GC is at worst 2.5% slowdown overall for GC = intensive > workloads. It may not sound much but to a performance engineer this is actually = quite a catch. This is because it's additive and independent of other = improvements, and Emacs GC being what it is, it's also a matter of = latency. If we only bothered with performance changes that give 50 % = speed-up or more then we would never get anywhere at all.