From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Sun, 25 Apr 2021 15:15:16 -0500 Message-ID: <9345da0c8f29d721203385187bee4dad6468cff3.camel@johnmuhl.me> References: <1398d749303cdc2a490cd9eb35f88fcf@johnmuhl.me> <87sg3ei23u.fsf@gnus.org> Reply-To: email@johnmuhl.mx Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33574"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jessenzr@gmail.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 25 22:17:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lalBh-0008da-5I for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Apr 2021 22:17:05 +0200 Original-Received: from localhost ([::1]:33498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lalBg-0005cS-9T for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Apr 2021 16:17:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lalAN-0004fP-7m for emacs-devel@gnu.org; Sun, 25 Apr 2021 16:15:43 -0400 Original-Received: from out2.migadu.com ([188.165.223.204]:50542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lalAH-0001cb-Uw for emacs-devel@gnu.org; Sun, 25 Apr 2021 16:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=johnmuhl.me; s=key1; t=1619381733; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oLqnfKpoE2SXIz5YyVqCu/jnzDw5xZ47l+K9S0vN6C8=; b=vn4nVBCxAd1BgQ7FSnT7+LcHkBBzWSyJzmZkubLC1DXoXAscaNCyAKhUpmxrNksqxm0Yin 7sjw7IPrrX1Y2rUS5c7amLQTvCgXxn54csYCL7AI1uLKTjwilz/5P2n5Q35+giWd9xeHEg Vz/8NVZnfBaNAoA80SCgCQobZaxDQuk/CXou3BDLG/GmlibiJAlfzXuO4vXKL5LAkyALGL Ih6U04gpDl73ib5CaU95TvHUimF3W4pPYoe4CJJurq6Zl5sCO3SRglNXzB+rfwsJI5zDm4 QfRW2sY3+Hqja8i5Ay3HrpQHg/UAyCTwI1eEtiyAjvmB3mg1EoCYatC0N1eUmg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <87sg3ei23u.fsf@gnus.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: email@johnmuhl.me Received-SPF: pass client-ip=188.165.223.204; envelope-from=email@johnmuhl.me; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268421 Archived-At: On Sun, 2021-04-25 at 21:41 +0200, Lars Ingebrigtsen wrote: > email@johnmuhl.me writes: > > > I am interested in this landing and contacted (and cc'd) Jesse and > > the > > FSF paperwork was completed around June 2020. Is there anything else > > holding this back now? > > > > https://lists.gnu.org/archive/html/emacs-devel/2020-01/msg00721.html > > has links to the previous discussion. > > I've included the patch below. > > I've never used the `line-spacing' variable myself (and my guess is > that > few do, which is probably why your message didn't get any responses), > but I did a > >   (setq line-spacing 20) > > now, and I see that this puts more space at the bottom of the line.  > The > proposed patch allows centring instead, which seems eminently > reasonable > to me.  (Perhaps this should even be the default?) > > Does anybody have any comments here before I apply the patch? > Thanks for taking look. I've been using the proposed patch the last couple of weeks and it works for me. The echo area does not handle it perfectly but it also doesn't perfectly handle the current behavior of non-nil line-spacing so hopefully not a blocker for landing. I added the following line to make it settable from customize. --- lisp/cus-start.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/cus-start.el b/lisp/cus-start.el index b7afef6516..21ad616cc9 100644 --- a/lisp/cus-start.el +++ b/lisp/cus-start.el @@ -154,6 +154,7 @@ minibuffer-prompt-properties--setter "21.1") (line-spacing display (choice (const :tag "none" nil) number) "22.1") + (line-spacing-vertical-center display boolean "28.1") (cursor-in-non-selected-windows cursor ,cursor-type-types nil :tag "Cursor In Non-selected Windows" --