From: Daniel Mendler <mail@daniel-mendler.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Setting `minibuffer-completion-table` buffer-locally
Date: Sat, 24 Apr 2021 13:08:35 +0200 [thread overview]
Message-ID: <931a4f41-44fd-a7d2-46e6-86b8cdffb0cf@daniel-mendler.de> (raw)
In-Reply-To: <jwvim4c2yii.fsf-monnier+emacs@gnu.org>
On 4/24/21 4:56 AM, Stefan Monnier wrote:
> Following a long discussion in bug#45474, I'm warming up to the idea to
> install the patch below which changes `completing-read(-default)` such
> that it sets the `minibuffer-completion-*` variables buffer-locally in
> the mini-buffer instead of let-binding them globally.
I am in favor of such a change. In the completion systems or packages
centered around completion I am involved with (Selectrum, Vertico,
Marginalia, Consult, Embark, ...) we always followed the style of
encapsulating minibuffer-local state inside the minibuffer. Let-binding
the built-in table always seemed odd. I don't expect breakage from
these packages. If some issues occur despite my expectations we will fix
them promptly. It is no problem to fix issues in a backward compatible
way by always accessing the minibuffer-completion-table via the
minibuffer, if for some reason the variable is accessed from the context
of another buffer.
Daniel
next prev parent reply other threads:[~2021-04-24 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 2:56 Setting `minibuffer-completion-table` buffer-locally Stefan Monnier
2021-04-24 11:08 ` Daniel Mendler [this message]
2021-04-24 11:15 ` Basil L. Contovounesios
2021-04-24 13:38 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=931a4f41-44fd-a7d2-46e6-86b8cdffb0cf@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).