From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 60102016e4: Abolish max-specpdl-size (bug#57911) Date: Tue, 20 Sep 2022 14:49:40 +0200 Message-ID: <9311F07F-9D1C-41F5-9D39-0B6233CA6A55@acm.org> References: <166360889903.6127.6574959318930089210@vcs2.savannah.gnu.org> <20220919173459.EC224C00872@vcs2.savannah.gnu.org> <87pmfrqjvc.fsf@gnus.org> <87r106mecp.fsf@gmx.de> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel , Alan Mackenzie , Stefan Monnier To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 20 18:37:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oagFs-0006Pa-9H for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 18:37:52 +0200 Original-Received: from localhost ([::1]:50764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oagFc-00028n-Op for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 12:37:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oachV-0004ds-D5 for emacs-devel@gnu.org; Tue, 20 Sep 2022 08:50:18 -0400 Original-Received: from mail1466c50.megamailservers.eu ([91.136.14.66]:49278 helo=mail268c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oachS-0005J3-9B for emacs-devel@gnu.org; Tue, 20 Sep 2022 08:50:09 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1663678185; bh=Q79iP0W+sssj3MDKb3+GHGKi1MBNlNd86wOjKLduvLM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=lLSzHvFaFEeG5GQIlaB7oYywXeYlJ3YRPcLUrdgUM8RnV1LXBZE2/xZ/Stlhd02ES 41O0DcOEMF5ggwYTBuxyq4GUEE25Av2TSSwsNmjLncZ/obg5cbcBIWwXYi2zlgqccM oCKqjv5Ld5xQZIlWNxr/3p+v3ZXX/I7kTC8hyRCw= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 28KCnfir031683; Tue, 20 Sep 2022 12:49:42 +0000 In-Reply-To: <87r106mecp.fsf@gmx.de> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F16.6329B6E9.000E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.66; envelope-from=mattiase@acm.org; helo=mail268c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295817 Archived-At: 20 sep. 2022 kl. 14.15 skrev Michael Albinus : > Tramp needs this for Emacs 26. I've wrapped it with = `with-no-warnings'. Thank you, but maybe silencing all warnings in the affected code was a = cudgel heavier than the situation called for? Perhaps something like this would do: > (defmacro tramp--with-max-specpdl-size (new-limit &rest body) > (declare (indent 1)) > (if (< emacs-major-version 29) > `(let ((max-specpdl-size ,new-limit)) . ,body) > `(progn . ,body)))) Or we could postpone the obsoletion for a while. The change was made = partly for user convenience, but the typically package maintainer may = not agree that this has been achieved: there is no way to be avoid = warnings in code that has to work on previous Emacs versions without = making it uglier. Would it be a bad idea to, say, make a note to obsolete max-specpdl-size = in Emacs 31?=20