From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Joshua Varner Newsgroups: gmane.emacs.devel Subject: Re: doctor.el Date: Sat, 2 Jul 2005 17:56:59 -0500 Message-ID: <92a5eb47050702155627ac4ec7@mail.gmail.com> References: Reply-To: Joshua Varner NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1120345585 26604 80.91.229.2 (2 Jul 2005 23:06:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 2 Jul 2005 23:06:25 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 03 01:06:16 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dor3s-0001J6-Ph for ged-emacs-devel@m.gmane.org; Sun, 03 Jul 2005 01:06:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dor50-0006R5-O1 for ged-emacs-devel@m.gmane.org; Sat, 02 Jul 2005 19:07:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DoqwT-0002mk-HH for emacs-devel@gnu.org; Sat, 02 Jul 2005 18:58:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DoqwE-0002gE-8E for emacs-devel@gnu.org; Sat, 02 Jul 2005 18:58:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Doqw9-0002Z1-Jz for emacs-devel@gnu.org; Sat, 02 Jul 2005 18:58:13 -0400 Original-Received: from [64.233.162.203] (helo=zproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dor0P-0005oc-AW for emacs-devel@gnu.org; Sat, 02 Jul 2005 19:02:37 -0400 Original-Received: by zproxy.gmail.com with SMTP id v1so315310nzb for ; Sat, 02 Jul 2005 15:56:59 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=nyx17s/dNGJS83iuGojnLEhGf4x+yeEP3GqHk5rn/gjKSk7LSafREHk6B1ZfqpOtlHLbc9U09/WQkp9oN+Z5Q7DzhXJRDDnIHUU5PCAIjbwNZZJwsIXK0c8v3uchl+MBkoQmx6/wuXZhvm5TfTKI2QADIbq2xgOASN/n76fWDPA= Original-Received: by 10.36.138.9 with SMTP id l9mr1052461nzd; Sat, 02 Jul 2005 15:56:59 -0700 (PDT) Original-Received: by 10.36.97.4 with HTTP; Sat, 2 Jul 2005 15:56:59 -0700 (PDT) Original-To: rms@gnu.org In-Reply-To: Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40161 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40161 On 7/2/05, Richard M. Stallman wrote: > Would someone like to fix doctor.el so that the variable names > start with `doctor-'? >=20 > You could do this either by renaming the references too, or by > changing the code to add `doctor-' when it accesses a variable > name from one of these doctor specs. I think the latter would be > cleaner. >=20 I took a look at this and had a couple of questions. There are a number a variables that are made buffer local, that are unique to doctor.el should those be prefixed as well? When you mention the 'doctor specs' are you referring to the below: (defun doctor-meaning (x) (get x 'doctor-meaning)) (defmacro doctor-put-meaning (symb val) "Store the base meaning of a word on the property list." (list 'put (list 'quote symb) ''doctor-meaning val)) doctor-put is called on a bunch of global symbols, but the property is prefixed by 'doctor-', if these are the ones you want converted would it be better to not use properties at all, or to create a variable and store the value of the property in it instead of in a property on the new doctor- variable? TIA, Josh P.S. I haven't signed papers, so if I do this I should probably get that process started.