From: martin rudalics <rudalics@gmx.at>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 05705454d5: Don't transfer window attributes trying to find the XM drag window
Date: Mon, 19 Sep 2022 09:43:50 +0200 [thread overview]
Message-ID: <91cb7982-ef2a-3338-78c9-534f0712dc1e@gmx.at> (raw)
In-Reply-To: <87tu53rfjx.fsf@yahoo.com>
>> Thanks, the problem seems fixed here. Could you please also add a
>> one-liner like
>
> Shouldn't we not run hooks for such events with dead frames?
You mean something like
diff --git a/lisp/frame.el b/lisp/frame.el
index 56a982562d..c7181d9162 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -239,7 +239,8 @@ handle-move-frame
This function runs the abnormal hook `move-frame-functions'."
(interactive "e")
(let ((frame (posn-window (event-start event))))
- (run-hook-with-args 'move-frame-functions frame)))
+ (when (frame-live-p frame)
+ (run-hook-with-args 'move-frame-functions frame))))
\f
;;;; Arrangement of frames at startup
and you're certainly right.
martin
next prev parent reply other threads:[~2022-09-19 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0850989a-ce12-5b35-8dfd-51c244a2b407@gmx.at>
[not found] ` <87pmfsrvqp.fsf@yahoo.com>
[not found] ` <93a7c78d-efef-d69d-b70c-6dc9ac1f7d8e@gmx.at>
2022-09-19 7:25 ` master 05705454d5: Don't transfer window attributes trying to find the XM drag window Po Lu
2022-09-19 7:43 ` martin rudalics [this message]
2022-09-19 8:00 ` Po Lu via Emacs development discussions.
2022-09-19 9:16 ` martin rudalics
2022-09-19 10:18 ` Po Lu
2022-09-19 16:14 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91cb7982-ef2a-3338-78c9-534f0712dc1e@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).