From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Wed, 06 Apr 2022 22:34:00 +0200 Message-ID: <91135A5B-17B9-4B1A-AFB9-40D2656313DE@aol.com> References: <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> <86czhw4oqr.fsf@mail.linkov.net> <4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com> <86bkxfibdo.fsf@mail.linkov.net> <20220405232013.5y5jnr4ykzqgxqla@Ergus> <86a6cyiqlt.fsf@mail.linkov.net> <20220406132108.evlofp5l3krsl5h7@Ergus> <86sfqqduon.fsf@mail.linkov.net> <20220406181339.iubahj6fviq3fyqv@Ergus> <86o81eawnv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9454"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 06 22:35:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncCNT-0002Ga-Jl for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Apr 2022 22:35:43 +0200 Original-Received: from localhost ([::1]:35864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncCNS-0005Qt-7A for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Apr 2022 16:35:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncCM6-0004gU-FO for emacs-devel@gnu.org; Wed, 06 Apr 2022 16:34:19 -0400 Original-Received: from sonic307-2.consmr.mail.bf2.yahoo.com ([74.6.134.41]:33800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncCM4-0002bL-0v for emacs-devel@gnu.org; Wed, 06 Apr 2022 16:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1649277252; bh=uwD3MhdyE33VHiI92yyhOXtPba4gFHd1TahKl0aOeaE=; h=Date:From:To:CC:Subject:In-Reply-To:References:From:Subject:Reply-To; b=Oc64LTsCnluyYXtqpfX484PB6yD+GsvNNPfpXMpw0rdnxj7AoE/3JM3mSe/1ggwmdxjMN0yyYCongqttuSvBcisjWjDlL2MFeR3eg1t7J888ORPBgqwyz34cfJPEjR0XNKJzJSb6IFGzU3BtxxLi9Gjh4MiDfSjLNdHbLHHArZ7n9ROCGDS8WCVRYZGONPwhzn2Kva5gGJoTpr0prmDFASIZm4RVlgOXCOmc5fMp/P2LhHalsnScijFonwQaPRlLT8qUVZWvWZ8CLChJju3+cmFcIqV+nVYIREN4ZMsUmXJI5/X5lvho2Dcuemprg4Ibu0mxozqsncY269DFndK16g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649277252; bh=KKJWnuIkh9tJ7j+AdkZHyGVIeEK5yM8nTlAf8uR3CYS=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=nOl8T2IXsBZ3tT+zqCswUw+ppoJmo34quSCEtXd+KxK72q9dJVz62LrBYWHWkUM9hMXmDU0rKThyVK7+5WrbPHmRHvjbmwqkVJP3psMprcPHcRCrCU4Gg1NEZ/HZq4mDoHhc2cnbmFWLrR5dffU/YjBjs+d1hiitEfOOGsa6hlpw5N6cTivDKDhC+g6rF1dtWkpl3A5nqbEvcV50nGEVRdyuExaNh4KLwl1osZNtw7YcwsiIJv4OdiCCxOcQo+LHBUSwQSP/OrI0um/8W/USAEu9So7BmoKQqgox7DYUHKKXXI9c/cRayxvepXmlX6TtNh8al9/gM+QZtPYb6rYXEQ== X-YMail-OSG: 6f2CCJMVM1lbEW0F._r6J81zCMQ.0489Z5.rdWmZROA3.NCSqAt_BGaQTmzbthD HWxKGHuKGeuWQBHiqXFR56jfee38EPyXto_jAyPrW_tSTTZfrK.pe2GK36OFqklrLsjBFDqfn66o kJkbzO4rYD9kNdLAk9i_AWgiue_9O_u.OlorAjF_mdWiKAE81kimhqPio5F2edJg.Q_9vNVLLwh8 W7RNbtYzr..RCLRVhSb68KPmqT2av6Kfk01AdfDnpIIbJi4gBG2awzn0cOpEUfSF_FZPlM8eWVaT XGNwL2uYPDJ9JJZDhMw1MfI4b67jeFeG7KJ18KgdPje7ns1BmE8hCWpeGLdOnaFD1waCv3svnFEM k7p7k2j6LgwlYk3FMNxZfxADBXcm_c5jaN_FMmD5ZX__HERjhdve.sydSQC0qV9ZCMCWQGg1IEdW b9co8hKjG7FJFeHMmnCuhbhsdbJGwhgviIqxn.bHa9Vc7kuU0cOwMBvsaaj4ejBjtC50C0jJXovC lj3OgKf2ohYPaUOFu1aIiGUFEHN4ajL4OTtrXQOsfgF6IC3x5dCISZORs0Tcj0YgKg2f2HHBos3Z wFiLU5OR3kPUNK8jC.l8o5z3Tn6ikK__yWHe3s21sS2T5hTJhAiXoydlsiU9PUZ9SofxHJkONB_h JE_W_JP2S0e0U0rgKxDFm3pWeSSD7l.f98liiJhDfqFO8fEAx0ygRaRDRqvr0rSSXK84aNzOOvBf buOz1QSNYFUu6DKVBYiB.H2leVTAeVSqWoxL.TFpgdi7yVgBxzpMGW9sHVmpNp19FvDpC1FP3A1y B2Oj0PhkZkdt.Dqs9t1AQ43925sh.VjiPSsbIVfYob X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.bf2.yahoo.com with HTTP; Wed, 6 Apr 2022 20:34:12 +0000 Original-Received: by kubenode510.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID a5b72720642c5e6e85a2e8c5d1a4aad1; Wed, 06 Apr 2022 20:34:06 +0000 (UTC) In-Reply-To: <86o81eawnv.fsf@mail.linkov.net> X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.134.41; envelope-from=spacibba@aol.com; helo=sonic307-2.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287860 Archived-At: On April 6, 2022 8:34:12 PM GMT+02:00, Juri Linkov wro= te: >>>Here is the next patch that does this and allows using all arrow keys >>>only when the completions window is visible: >> >> Ok quick check :) >> >> With the new option the behavior gives a much better navigation=2E >> >> 1) There is still the issue with C-g or ESC canceling everything > >Do you mean addition step is needed where first C-g/ESC will clear >the suffix, then another C-g/ESC will exit the minibuffer? > We need a simple handy way to restore the mini-buffer as it was before the= navigation attempt=2E=2E=2E Maybe, let's look more at zsh and similes=2E=2E=2E That's already tested t= o be intuitive so we don't need to reinvent the wheel and their users alrea= dy know=2E >> 2) In tabular navigation the down arrow always goes to the first column >> which is wrong; maybe it should use next-line or line-move instead of >> forward-line? > >This is what I tried first, but byte-compiler complained next-line >is only for interactive use=2E > Then it should probably be line-move but forward-line goes to column zero= =2E >> 3) It still needs and extra binding to insert and then to another >> execute=2E=2E=2E RET just removes the highlight and nothing else=2E=2E= =2E which is >> un-intuitive because the candidate in principle is already selected=2E > >Then it should always insert the selected candidate=2E > At the end I think that I will stay with completion-auto-select second-tab= + completion-auto-help visible=2E=2E=2E It is closer to my desired behavior= as is=2E There are just some missing details probably I will try to solve = step by step if they become annoying enough=2E I don't like that this is getting complex and full of customs and variants= that will be hard to support in the future=2E=2E=2E I would recommend to r= evert all this changes from master and move them to a branch untill we clar= ify what we want and what is possible to implement cleanly =2E >> I am not a good lisper, but I think that an approach with a minor mode >> or a transient-map could end up being simpler and more modular without >> adding more complexity in the existing code=2E=2E=2E WDYT? > >A minor mode that adds a hook to minibuffer-setup-hook >that activates another mode with additional keymap? >Looks more complex=2E And a transient-map on post-command-hook >is even more complicated=2E But mixing all these bindings behaviors and features all together is somet= hing that will break sonner than later=2E And the hybrid behavior will end = up not being good enough for user who want a zsh experience and will bother= the ones who don't=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E