unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: emacs-devel@gnu.org
Cc: Andrey Kotlarski <m00naticus@gmail.com>
Subject: Re: master e869ae2: Fix EBROWSE parsing of classes declared final.
Date: Thu, 03 Jan 2019 12:42:45 -0500	[thread overview]
Message-ID: <90ef9tvdre.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20190103120905.9C66320CAB@vcs0.savannah.gnu.org> (Andrey Kotlarski's message of "Thu, 3 Jan 2019 07:09:05 -0500 (EST)")


Hi,

Re this:

> commit e869ae200db8378ab50957b8d357888e78fe0aac
>
>     Fix EBROWSE parsing of classes declared final.
> ---
>  ChangeLog.3       |  9 ++++++++
>  lib-src/ebrowse.c | 68 +++++++++++++++++++++++++++++++++++++++++++------------
>  2 files changed, 63 insertions(+), 14 deletions(-)
>
> diff --git a/ChangeLog.3 b/ChangeLog.3
> index decee10..df2b167 100644
> --- a/ChangeLog.3
> +++ b/ChangeLog.3
> @@ -1,3 +1,12 @@
> +2019-01-03  Andrey Kotlarski  <m00naticus@gmail.com>
> +
> +	Fix EBROWSE parsing of classes declared final
> +
> +	* lib-src/ebrowse.c (enum token, token_string, init_scanner):
> +	Handle final keyword.
> +	(member, class_definition, globals): Correctly determine class
> +	name in presence of final declaration.
> +

ChangeLogs are automatically generated files (since some time) and should
not be edited directly. Instead what you wrote in ChangeLog.3 should
have been the commit message. No big deal though. If you had written
that entry to the unversioned file "ChangeLog", log-edit-insert-changelog
(C-c C-a) would have inserted it into the vc-log buffer. This is covered
in CONTRIBUTE.





       reply	other threads:[~2019-01-03 17:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190103120903.22297.39666@vcs0.savannah.gnu.org>
     [not found] ` <20190103120905.9C66320CAB@vcs0.savannah.gnu.org>
2019-01-03 17:42   ` Glenn Morris [this message]
2019-01-03 18:56     ` master e869ae2: Fix EBROWSE parsing of classes declared final Andrey Kotlarski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90ef9tvdre.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=m00naticus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).