From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 20:39:24 +0300 Message-ID: <9037d0e0-74d6-1a6d-8a79-665fc4dd86f9@yandex.ru> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <83bks3vtf5.fsf@gnu.org> <83tu5uug68.fsf@gnu.org> <86o7w1zniw.fsf@mail.linkov.net> <83ler5u0fj.fsf@gnu.org> <4ee591ed-accb-57c3-b9bb-9e97435af492@yandex.ru> <83h71ttyyg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: juri@jurta.org, larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 19:53:02 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT5Q6-0007t0-4O for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 19:53:02 +0200 Original-Received: from localhost ([::1]:48972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT5Q4-0003aj-RN for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 13:53:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT5DN-0004lC-SV for emacs-devel@gnu.org; Tue, 30 Aug 2022 13:39:57 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:42804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oT5DL-0001SW-33; Tue, 30 Aug 2022 13:39:53 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id m16so15159865wru.9; Tue, 30 Aug 2022 10:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=iaHGZnXpQa5NfL+iZLj+fIgoz+cmhXqzFgI4ynzFsAo=; b=JJMjFLe6s+OyO6JknOGyBlvHT/oNoFlqN0pVubp00iuaq+Rh9F0QlpwiLpC7IZDje4 Hv3z7w8IBcMKZG9pyO2KymxPmpOUD7Nd/rSC+pfEWAEb+IqVXm2PidEk0Ycgu/5y0eWT 1hTZxDZajRsvx8/jlvFmEeG5aOuFEhTSqtjbzzOD/UC0UR8UPu255NF9orkmPMmd3YoX eLZB8ODDzeLtS8fQ34BDFB09e7lkRxi+BndBD5T4bsyHEbeD8UPxjELXHEK0rdY4x7UH hsKhMcJzSMKQosVBdLmeCTQSKo0gLYJ1QnmKYZF+uOaBHwXZ1jLZUVnqLtrdH6th5pMn DoUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=iaHGZnXpQa5NfL+iZLj+fIgoz+cmhXqzFgI4ynzFsAo=; b=DmWfbqJHbMJdzAVdHuJrMqu0G0s7Eozzcie8QlJCwwpbqRoLTnUiMijgoYSTM73lPC eeL4kRdfq5FY2O0s6K307mhCIfQJ8nHZW6nBxhJO4NNveMiNBoQHBZi2VKppKBZz1XL+ 4uJtyt9R8TLllJTUME3sWjuS+HHtKaiNLkiAn5UGJP6r6S+Q223JMJJbhgvWE2m36f7v gw6c6n8IbEeq94lzwUuJM8BQ/yc2Ued4IT1RenJgak+rW2EiS8JDtjWpbCYNwmlEtxzQ I8/VRtwpDaWHxIOy6a0oOUG0qVOYTnALz+Azwt3OeHUac00wTPnOXvW4AMNlEa8jqlvS Osew== X-Gm-Message-State: ACgBeo0hNUy37uurBLn8tQxgeebLqq5lcTBAHxoVh1UgpOw5Stwo1C96 pHSgWxQ91CcW4VDPtzp0scNBUsXLoHA= X-Google-Smtp-Source: AA6agR655fYAUqXaaoa88zVdvjzXHXjEtGuevJzR3cuEnIfPXxXAt9vhVzQh4Llq98tHjsk2BjjyIQ== X-Received: by 2002:adf:ee50:0:b0:225:7508:9d88 with SMTP id w16-20020adfee50000000b0022575089d88mr9727861wro.320.1661881165972; Tue, 30 Aug 2022 10:39:25 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o5-20020a05600c510500b003a31fd05e0fsm4447794wms.2.2022.08.30.10.39.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 10:39:25 -0700 (PDT) Content-Language: en-US In-Reply-To: <83h71ttyyg.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=raaahh@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294373 Archived-At: On 30.08.2022 20:37, Eli Zaretskii wrote: >> Date: Tue, 30 Aug 2022 20:11:52 +0300 >> Cc:larsi@gnus.org,emacs-devel@gnu.org >> From: Dmitry Gutov >> >> On 30.08.2022 20:05, Eli Zaretskii wrote: >>>> Indeed, just 'M-! git apply' before using 'vc-checkin-patch' will do the job >>>> in case of an external patch. >>> Unless some of the hunks are wrong or produce conflicts or are >>> rejected due to 1001 reasons. Which is exactly the use case I thought >>> this enabled. Sorry for misreading. >> Not sure how we could possibly automate that problem away. > You don't need to. Aborting a botched patch is easy; once the > problematic hunks are known (they are announced by Patch or by > "git apply"), you use this facility to filter them out, and > patch/commit again. But filtering those out is not what one usually wants to do. It's more common to want to install all the included changes, even if some might require fixing.