From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Date: Sun, 12 May 2024 19:03:36 +0300 Message-ID: <8f3b86fa-a7ee-4ef0-8953-944efb65f9df@gutov.dev> References: <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org> <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> <7be03e7e-6b8a-420c-b0d8-a512d7917cf2@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7652"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 12 18:04:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6BgT-0001cU-Ng for ged-emacs-devel@m.gmane-mx.org; Sun, 12 May 2024 18:04:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6Bfr-00012X-KX; Sun, 12 May 2024 12:03:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Bfp-000129-Bh for emacs-devel@gnu.org; Sun, 12 May 2024 12:03:41 -0400 Original-Received: from fout6-smtp.messagingengine.com ([103.168.172.149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Bfn-0002YI-Jh for emacs-devel@gnu.org; Sun, 12 May 2024 12:03:41 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id BDE1D1380232; Sun, 12 May 2024 12:03:38 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 12 May 2024 12:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715529818; x=1715616218; bh=P+PXOtAHGI2tCaHvU3jhQMY/hlNvCqL333xKLvgwGvs=; b= dvsm70aOUily27leEvmz4xUeP125C/c7g9nT5ULmsQK7w/zCYO4Qmn86xLFIIEra wmf6lUSKVCxzfsCZfY/NNCsZKtFBNL3Fti+H/LOcZl4vGvPULom9i/dnCipsdTxA 8T796psV0GefXFHgVwJ3HXQgbfnnbiFBQqxiLCcLPaMmoYKqc1vu1wIEEFHobT4f 31swxmt7fPVGZUk++E/ZMwshpcPvhXjTDIUNTum9VX1kuaPqIvZcxcN127DDeean 0cds/udVW54JJTEg/CjVqHqKcKhFee42DDmE8iphRhP828JJirljH8OPVu1v4cie ETesgqjlmQAwgX/79+6sMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715529818; x= 1715616218; bh=P+PXOtAHGI2tCaHvU3jhQMY/hlNvCqL333xKLvgwGvs=; b=g SnrzT4Ogn4zB01WfNoTe+CZa8whdkX1EsYM8toqRjzTAzKyYyGEzU19mA8fSqwWG lzMFZ/Aa3bk/D1ogQaLOdfFrK9464CsuO6H9e2LLWs9HBmqOj1BpXL+wtl6dF5hn Yp3IuZkLqSa+hKbl/mgNieCrJbDYbytXcVLRlWZxzarGEOi49u06eEvF9iUuNl6/ 4wewTemyLiNr09PP9fyPI84Ut1sdHU8TyFUqeuZQ1tyJiKasPnimYc2+GOAxYr8p ct6Ip3W2RCKZZqbi7KUDP82WvyeSHp1XJt3a38iRMlDTH9bP/DJS8/+JSokRPrDK ReB8n4o90gdg5Ym51yCSQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdegvddgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesth ejredttddvjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehg uhhtohhvrdguvghvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhe dvveeikeeufedtvddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 May 2024 12:03:37 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=103.168.172.149; envelope-from=dmitry@gutov.dev; helo=fout6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319189 Archived-At: On 12/05/2024 15:38, Eshel Yaron wrote: > Dmitry Gutov writes: > >> Hi Eshel, >> >> On 10/05/2024 19:10, Eshel Yaron wrote: >> >>>> branch: master >>>> commit ff3f17ca3cdd9e82355942f577e7807acc76ddcd >>>> Author: Dmitry Gutov >>>> Commit: Dmitry Gutov >>>> >>>> choose-completion: Retain the suffix after completion boundary >>>> >>>> * lisp/minibuffer.el (completion-base-suffix): >>>> Remove as not optimal after all (bug#48356). >>>> (completion--replace): Use insert-before-markers-and-inherit. >>> [...] >>> >>>> - (insert-and-inherit newtext) >>>> + (insert-before-markers-and-inherit newtext) >>> It seems that this change breaks the cycling behavior of >>> minibuffer-force-complete. You can see the problem by saying: >>> 1. emacs -Q >>> 2. (setq completion-cycle-threshold t) >>> 3. Open some buffers >>> 4. C-x b TAB TAB TAB ... >>> The repeated TAB presses are expected to cycle through the >>> completion >>> candidates (this is the behavior in Emacs 29 for example) but now each >>> TAB appends to the minibuffer input instead of replacing it. >> Thanks for reporting that. Indeed cycling was a special case because >> it tracks BEG with a marker. >> >> This should be fixed in commit f0009c2f5ae, hopefully without >> regressing on other cases. > Great, thanks! > I can't seem to find this commit, though, is that on master? My bad, that push didn't go through. Now on master. The new commit hash is 2c759b9ce620.