From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Wed, 2 Jun 2021 02:04:56 +0300 Message-ID: <8e33bbfe-0015-b85c-b57c-ba448f2e6215@yandex.ru> References: <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <871r9laj6a.fsf@gmail.com> <1b73a130-204c-76fb-2b60-02b814aee0f0@daniel-mendler.de> <87r1hl8xom.fsf@gmail.com> <878s3t8tzw.fsf@gmail.com> <3c68bd00-70ca-fa18-f9b8-cd03029f9294@daniel-mendler.de> <8735u18lsd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29387"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: Juri Linkov , monnier@iro.umontreal.ca, "emacs-devel@gnu.org" To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 01:06:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loDSb-0007YL-Vq for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 01:06:09 +0200 Original-Received: from localhost ([::1]:53482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loDSb-0006tT-0g for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 19:06:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loDRW-0005jR-R1 for emacs-devel@gnu.org; Tue, 01 Jun 2021 19:05:02 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:34761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loDRU-00053y-RZ for emacs-devel@gnu.org; Tue, 01 Jun 2021 19:05:02 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id q5so295979wrm.1 for ; Tue, 01 Jun 2021 16:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mQdX6+QPM3u5qOZByD6v3VVOJ4Ri5oojBHF1bkdx8C8=; b=XPbZHLS7f3q9oY0wkobkNq1KLvwygucRSFy1tCGxKDyCHQOVWk73PxWXoCFGyxXfET 8UZ7d5pmPtVra/EpOk1jQIvODch//Cg1Amw3UJkavFZnX/1jccx0n+b0gnf+lHUcB0UM C8n5n0OWFdhe02JAqgUlMkOgPTGMpbSZFA2MlHuFILJM7u92gsWOF9Hx05e1nm9WaqNH 5FPKHCTMbt0IoEEw1lLhXnGS9aP6gp59qUYarqHGVEINsh9qMMyqfhMuKjL3vSd799b0 IdPm//BYghInMmOSolI3j7PYqrpb+UwVBE8gW1m2FKwut+HS/KZwCeIiIeOQRTJFQ9Rn F+WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mQdX6+QPM3u5qOZByD6v3VVOJ4Ri5oojBHF1bkdx8C8=; b=TKkOy7vupaIoek0Pkwb1i0g4x2LsBreCaG4Fw0iR0Q3LRecGqXo0lTV7Rvn//HoC85 cm/Do68tsDIoBTPDAOZiykp9uGJqImaqpgqA8dQF3CMtjGBvN5zLFOsKgvSnkhKLoLzH tXvhLwjcTtebsmTIr1krRS7mlR+Hh9XQxVP9GoKNfKOhs6F1gwl/Z/VapPqqAT3mVWvL X4N9SZY9xM/qJFr8io0+hZJ0JG5ODE9hHnpdJSKePfauXAZ+3efuKUV7jYJwkJJySfQY D+REkOXxJSHxWcZKXnzf5zpKp9paeGKRTKJKkeyUpR6PVFanbOx/FI50MJCUpQEiwT+t bGCw== X-Gm-Message-State: AOAM531gwOUMKG6eK3mIxglqlQ9coSeQtRQYa4/FHK24PCDmR7JJB2pc wNcvqELq6w917/g6wPj3S/Q= X-Google-Smtp-Source: ABdhPJwH6wK8YHI/uWEx2iNied9ahIO9tYmdnxu3mg6OsQSrQWppCL2eL5ZavZkc2Rd+7TaJhdO3mA== X-Received: by 2002:adf:df8d:: with SMTP id z13mr29939099wrl.267.1622588699390; Tue, 01 Jun 2021 16:04:59 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p9sm708938wmq.48.2021.06.01.16.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 16:04:57 -0700 (PDT) In-Reply-To: <8735u18lsd.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.613, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270257 Archived-At: On 01.06.2021 21:47, João Távora wrote: > In what way? Really, all other things being equal, in what way is > threading arguments through lots of functions, bloating the arglist, > implementations and the docstrings of said functions, calling group-fun > multiple times and in multiple places in minibuffer.el better than_not_ > doing those things? Why do you think it forces you to "thread" them? Firs of all, you can construct the same composite values you wanted using the current calling convention of the group-function. And then use them the same way. Whether this results in better minibuffer.el code is debatable: your diff has more additions than deletions, and one rather long line. OTOH, someone in a different codebase might appreciate that the group-function decouples the mapping to group names from the transformations of the items, and thus one can do the latter closer to where the items are printed, instead of having to "thread" the transformed values to their place of use (from where the grouping logic was called). Using a text property is a handy workaround, but ideally one shouldn't have to use it.