From: "David De La Harpe Golden" <david.delaharpe.golden@gmail.com>
To: "Jan D." <jan.h.d@swipnet.se>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Improving X selection?
Date: Tue, 5 Feb 2008 03:38:16 +0000 [thread overview]
Message-ID: <8e24944a0802041938j5528d9b3nb72e1c8d9a960dd6@mail.gmail.com> (raw)
In-Reply-To: <8e24944a0802041302n45064c4fm2ac428ceda204254@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
On 04/02/2008, David De La Harpe Golden wrote:
> That didn't matter
> before (because nothing was trying to propagate out the active region
> when the point moved), with select-active-regions the order of
> move-point/deactivate-mark vs. deactivate-mark/move-point during
> mouse-set-point is significant.
>
> Guess should next trace exactly where in the call stack the region
> deactivation is occurring in unpatched emacs.
>
Right. This happens (unconditionally as far as I can see) in
mouse-drag-track, which happens on mouse down. Moving the
deactivate-mark to happen before the initial point move (which
mouse-drag-track does with mouse-set-point...) rather than after fixes
the select-active-regions behaviour, and I doubt it matters much
otherwise?
[and avoids damaging mouse-set-point's behaviour for those who like to
unbind dragging from the mouse and use different buttons to set the
mark and point, say...]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mouse-drag-track-deactivate-mark-earlier.diff --]
[-- Type: text/x-diff; name=mouse-drag-track-deactivate-mark-earlier.diff, Size: 1203 bytes --]
Index: lisp/mouse.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mouse.el,v
retrieving revision 1.326
diff -u -r1.326 mouse.el
--- lisp/mouse.el 8 Jan 2008 05:12:50 -0000 1.326
+++ lisp/mouse.el 5 Feb 2008 03:29:30 -0000
@@ -925,6 +925,11 @@
The region will be defined with mark and point, and the overlay
will be deleted after return. DO-MOUSE-DRAG-REGION-POST-PROCESS
should only be used by mouse-drag-region."
+ ;; this function defines a new region, so deactivate mark before first
+ ;; moving point, to avoid briefly resizing the previous active region
+ ;; if any. Such a brief resize can produce poor behaviour when
+ ;; select-active-regions is enabled.
+ (deactivate-mark)
(mouse-minibuffer-check start-event)
(setq mouse-selection-click-count-buffer (current-buffer))
(let* ((original-window (selected-window))
@@ -971,7 +976,6 @@
(mouse-move-drag-overlay mouse-drag-overlay start-point start-point
click-count)
(overlay-put mouse-drag-overlay 'window start-window)
- (deactivate-mark)
(let (event end end-point last-end-point)
(track-mouse
(while (progn
next prev parent reply other threads:[~2008-02-05 3:38 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 10:20 Improving X selection? Horsley, Tom
2007-10-15 11:06 ` Jan Djärv
2007-10-16 4:10 ` Richard Stallman
2007-10-16 23:29 ` David De La Harpe Golden
2007-10-17 1:05 ` David De La Harpe Golden
2007-12-25 21:13 ` Richard Stallman
2008-01-28 19:52 ` David De La Harpe Golden
2008-01-29 0:59 ` David De La Harpe Golden
2008-02-01 19:15 ` David De La Harpe Golden
2008-02-02 0:17 ` David De La Harpe Golden
2008-02-03 11:38 ` David De La Harpe Golden
2008-02-03 12:44 ` Jan D.
2008-02-03 13:12 ` David De La Harpe Golden
2008-02-04 21:02 ` David De La Harpe Golden
2008-02-05 3:38 ` David De La Harpe Golden [this message]
2008-02-05 7:08 ` Jan Djärv
2008-02-07 3:57 ` David De La Harpe Golden
2008-02-07 4:23 ` Miles Bader
2008-02-07 4:59 ` David De La Harpe Golden
2008-02-07 9:07 ` Jason Rumney
2008-02-07 16:32 ` David De La Harpe Golden
2008-02-07 17:11 ` David De La Harpe Golden
2008-02-07 17:13 ` Jason Rumney
2008-02-07 19:46 ` Stefan Monnier
2008-02-10 18:42 ` Richard Stallman
2008-02-11 17:46 ` David De La Harpe Golden
2008-02-07 17:25 ` Stefan Monnier
2008-02-07 17:39 ` David De La Harpe Golden
2008-02-07 17:51 ` David De La Harpe Golden
2008-02-07 19:54 ` Stefan Monnier
2008-02-07 15:14 ` Stefan Monnier
2008-02-07 16:15 ` David De La Harpe Golden
2008-02-07 18:01 ` Stephen J. Turnbull
2008-02-07 18:07 ` David De La Harpe Golden
2008-02-07 19:21 ` Stephen J. Turnbull
2008-02-08 1:19 ` Miles Bader
2008-02-08 1:42 ` David De La Harpe Golden
2008-02-07 18:22 ` David De La Harpe Golden
2008-02-07 19:45 ` Stefan Monnier
2008-02-07 20:39 ` David De La Harpe Golden
2008-02-07 21:25 ` Stephen J. Turnbull
2008-02-07 21:41 ` David De La Harpe Golden
2008-02-08 0:22 ` Stephen J. Turnbull
2008-02-08 1:26 ` David De La Harpe Golden
2008-02-07 22:43 ` Stefan Monnier
2008-02-08 2:50 ` David De La Harpe Golden
2008-02-08 13:26 ` OT [was Re: Improving X selection?] Tom Horsley
2008-02-08 15:30 ` David De La Harpe Golden
2008-02-08 16:07 ` OT Stefan Monnier
2008-02-08 16:43 ` OT David De La Harpe Golden
2008-02-08 14:41 ` Improving X selection? Stefan Monnier
2008-02-08 15:21 ` David De La Harpe Golden
2008-02-17 3:38 ` David De La Harpe Golden
2008-02-17 3:55 ` David De La Harpe Golden
2008-02-07 21:01 ` Tom Horsley
2008-02-07 21:18 ` David De La Harpe Golden
2008-02-07 21:36 ` Tom Horsley
2008-02-07 21:40 ` David De La Harpe Golden
2008-02-07 22:51 ` Stefan Monnier
[not found] ` <8e24944a0802071042u43d68f04pc8492ad8ce07aa18@mail.gmail.com>
2008-02-07 18:44 ` Fwd: " David De La Harpe Golden
2008-02-03 16:18 ` Richard Stallman
2008-02-03 18:29 ` David De La Harpe Golden
2008-02-05 5:58 ` David De La Harpe Golden
2008-02-05 6:23 ` Miles Bader
2008-02-05 6:56 ` David De La Harpe Golden
2008-02-03 16:18 ` Richard Stallman
[not found] <20071012105022.6c8b174a@tweety>
2007-10-14 16:29 ` Richard Stallman
2007-10-14 17:25 ` Jeremy Maitin-Shepard
2007-10-15 6:19 ` Jan Djärv
2007-10-15 6:21 ` Jan Djärv
2007-10-15 6:41 ` Eli Zaretskii
2007-10-15 6:55 ` Miles Bader
2007-10-15 8:16 ` Jan Djärv
2007-10-15 14:21 ` Stefan Monnier
2007-10-15 18:30 ` Richard Stallman
2007-10-15 19:26 ` Jeremy Maitin-Shepard
2007-10-15 20:03 ` Andreas Schwab
2007-10-15 20:22 ` Jeremy Maitin-Shepard
2007-10-16 8:02 ` Frank Schmitt
2007-10-16 7:27 ` Jan Djärv
2007-10-16 10:08 ` René Kyllingstad
2007-10-16 13:15 ` Stefan Monnier
2008-08-18 15:29 ` René Kyllingstad
2008-08-18 18:47 ` David De La Harpe Golden
2008-08-18 19:16 ` David Hansen
2008-08-19 8:06 ` Frank Schmitt
2008-08-25 15:34 ` Juri Linkov
2008-08-25 15:56 ` Frank Schmitt
2008-08-28 17:45 ` David De La Harpe Golden
2008-08-28 17:58 ` Frank Schmitt
2008-08-28 18:19 ` David De La Harpe Golden
2008-08-29 5:53 ` David Hansen
2008-08-30 4:08 ` David De La Harpe Golden
2008-08-31 7:41 ` David Hansen
2008-08-20 22:41 ` David De La Harpe Golden
2008-08-25 15:34 ` Juri Linkov
2008-08-26 3:09 ` David Hansen
2008-08-26 8:03 ` David De La Harpe Golden
2008-08-26 8:41 ` David Hansen
2007-10-16 7:26 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e24944a0802041938j5528d9b3nb72e1c8d9a960dd6@mail.gmail.com \
--to=david.delaharpe.golden@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).