From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: Brittleness of called-interactively-p Date: Fri, 17 Jul 2015 18:47:17 -0700 (PDT) Message-ID: <8d4c452d-4122-4526-a7ec-02886156c5df@default> References: <871tgeufzt.fsf@gmail.com> <87r3odtngi.fsf@gmail.com> <87380st7c1.fsf@gmail.com> <56ffd903-483b-49cf-acf1-f17c1231537e@default> <21927.61661.861463.374658@retriever.mtv.corp.google.com> <10fdfb19-16c4-48f4-bb0d-d761163c11d5@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1437184080 10057 80.91.229.3 (18 Jul 2015 01:48:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Jul 2015 01:48:00 +0000 (UTC) Cc: dpaduchikh@gmail.com, emacs-devel@gnu.org, Richard Stallman , monnier@IRO.UMontreal.CA To: raman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 18 03:47:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZGHE6-0002XV-2o for ged-emacs-devel@m.gmane.org; Sat, 18 Jul 2015 03:47:42 +0200 Original-Received: from localhost ([::1]:46617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGHE5-0008Ik-1y for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2015 21:47:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGHDs-0008Id-6d for emacs-devel@gnu.org; Fri, 17 Jul 2015 21:47:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGHDo-0005Ry-78 for emacs-devel@gnu.org; Fri, 17 Jul 2015 21:47:28 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:46046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGHDo-0005Rh-0O; Fri, 17 Jul 2015 21:47:24 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t6I1lLBd006648 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 18 Jul 2015 01:47:21 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t6I1lJtj019424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 18 Jul 2015 01:47:19 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t6I1lJrP020865; Sat, 18 Jul 2015 01:47:19 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 156.151.31.81 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187941 Archived-At: > Drew, > Yes, the old interactive-p did it perfectly, but it also broke for me > somewhere in the advice transition, actually it took me a while to > realize that it was broken; from memory I tracked down the problem after > one of the emacspeak users reported a recursive hang/crash in ruby-mode. By "in the advice transition" I guess you mean the change to using the new advice system. Does `interactive-p' still work OK with the "old" advice system? If so, perhaps you could use that, and perhaps file a bug or feature enhancement request for the new advice system. IOW, if it hurts to do that ("upgrade"), consider not doing it. ;-)