From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 86c4e5a2fb3: Fix implicit declaration of bswap_{32,64} Date: Sat, 30 Mar 2024 10:44:56 -0600 Message-ID: <8c4fb0f8-4158-4390-b744-8d5775c4f070@cs.ucla.edu> References: <86zfugcexr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18631"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: Eli Zaretskii , Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 30 17:45:40 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqbps-0004ca-49 for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Mar 2024 17:45:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqbpR-00044P-9c; Sat, 30 Mar 2024 12:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqbpK-000448-Oq for emacs-devel@gnu.org; Sat, 30 Mar 2024 12:45:07 -0400 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqbpF-0001RC-Mp; Sat, 30 Mar 2024 12:45:06 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id D6FCB3C011BD9; Sat, 30 Mar 2024 09:44:57 -0700 (PDT) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id aQ1i8JTRA8or; Sat, 30 Mar 2024 09:44:57 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8E4063C011BDA; Sat, 30 Mar 2024 09:44:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 8E4063C011BDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1711817097; bh=J+5UHVKSYXfP4ZVslXrAd25f3UtBJKddVWkpYm+NKjE=; h=Message-ID:Date:MIME-Version:To:From; b=epwfi8+aO0xY4a4+EZ8zBOBdF113YPevo3sxY/dgRXffpfheBX5w4Md0lUO9OcZpw D35CgJdDfL6798txYil6G0iW/VQxeaZMPzARWqqXNsBzPUGtrRW3qTRAxO1tYX2Exg vcO4233INLhoCYyOjM12py/yTRgKjqJsV+A9IllNYUts5NgMDiqmPooq1cjFbNvH8z 7jMT6gkH4y0Ra9mMCRGR1E0cIGOrmmi02UTJSUU5r++RTk2U48bb1N9y2F6kRRYzKh 9v8K92Yp7KnfWNbTmGR/4oOdxAGajvGLduWWB5FRkk2EE1+LCqv6164g5VBco8o4qb KVJ/28Q7VVS3A== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id cn9ttOZ8jcIR; Sat, 30 Mar 2024 09:44:57 -0700 (PDT) Original-Received: from [10.0.0.57] (c-98-245-1-133.hsd1.co.comcast.net [98.245.1.133]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 3B77E3C011BD9; Sat, 30 Mar 2024 09:44:57 -0700 (PDT) Content-Language: en-US In-Reply-To: <86zfugcexr.fsf@gnu.org> Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317398 Archived-At: On 3/30/24 02:16, Eli Zaretskii wrote: > Wouldn't it be better to use __builtin_bswap32 when it's available? > > Paul, why doesn't Gnulib do that in its byteswap.h header? I think Gnulib byteswap.h predates __builtin_bswap32. Not sure it's worth the hassle of using __builtin_bswap32 if available, as (as Andreas mentioned) that won't make Emacs go faster in the usual gcc -O2 case.