From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 25 May 2021 01:05:58 +0300 Message-ID: <8bd4bd9f-995a-4cdf-3159-338749d56739@yandex.ru> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87a6olazff.fsf@gmail.com> <93d2cfe9-bae8-bf94-486f-7569aa31491d@daniel-mendler.de> <874kesj6k6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8738"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: Juri Linkov , monnier@iro.umontreal.ca, "emacs-devel@gnu.org" To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 00:06:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llIiw-000293-6R for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 00:06:58 +0200 Original-Received: from localhost ([::1]:34954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llIiv-0007dy-AE for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 18:06:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llIi7-0006gE-BH for emacs-devel@gnu.org; Mon, 24 May 2021 18:06:07 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:33320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llIi2-0007ax-Pu for emacs-devel@gnu.org; Mon, 24 May 2021 18:06:07 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id n2so30110367wrm.0 for ; Mon, 24 May 2021 15:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5Lsic6/MmnNb9gR5+62hgJvFn3tRFXzMVK9yTP5QQFc=; b=kASWrqVprRz1M1wD91Lx8QrSawFecOJjM9eF3K7JMEt3ugzzR2P51/SHykP5+ywI7p Arcb016srnrFaHX0ykfJDTVgVS8jhiqVZow9B3xwghmR7rYlaBc25bETo43P4CxVLXaN PBiysv3UArEyoW1jZS116JnEe4nHADm3oLRP4PZ9xTtl8LKH0QByK8bYQLz8JP6/AzAl CErxYafEWCsNczPcQCmdfDLspJuQSJgg9J13jzg+qmzfM/saapnd0BLXiMUbxupGTgjs jESJVvypZjTDQQdvewRG6GPlypbPOVXcvj0XFeB7Bu3DLgKliNZC8EVJTPZfwtnTeM1h BmmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5Lsic6/MmnNb9gR5+62hgJvFn3tRFXzMVK9yTP5QQFc=; b=cLY+LC/P727xpDnrvyhJomTD724ryFEdAqduRX4ZFOEWN2ulGam8/952qHTIA6loZF h16sfLkERVr8JQKryf7k45pmYYWC6/q/VDbuJ8bcx47pdwBy1KmYuUf3YDPn9AJ2fqSJ 4m8PEI4w0A8rSUBq4wa6lb1y0YQ8ZASTRMjfwo+nqa37IXP3MLb1/ZktnP73POoSRllo +V4wlHPUyvEGQN/maKKBbimMowLbUef6BNAoqSl1echRqk+43zBEG8kxkoEjd+2f8oSz Cnli2zkRQQ5dEPvO7E5CKh1GYb72Xi45yP7rr0MjW7pbhuzJKMN4UTjmeQKhE2uIKCfw jMRg== X-Gm-Message-State: AOAM530VwjFPxJWI+/V7PBi0GCsujyWr0bolSe8s+mKpI6kQhRXYpD/I MZBXwIZty63FjQDdgByM3bk= X-Google-Smtp-Source: ABdhPJw7R5iC01LV30GF+r/PEUtZpHI1YD+DOJGK39LYg0ADMOl12ugwRj+Yixvj8g883DFoFOQN1g== X-Received: by 2002:adf:9f51:: with SMTP id f17mr23827311wrg.3.1621893961184; Mon, 24 May 2021 15:06:01 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n2sm11263221wmb.32.2021.05.24.15.05.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 15:06:00 -0700 (PDT) In-Reply-To: <874kesj6k6.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=raaahh@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269811 Archived-At: On 24.05.2021 22:05, João Távora wrote: > - One commit, titled "Overhaul annotation-function to match > affixation-function" makes annotation-function match its cousin in > capability and switches the two producers of affixation-function to use > annotation-function instead. It uses the logic we discussed before, > returning a propertized string. It should be backward and forward > compatible. TBH, I'm not quite happy with the prefix-suffix thing either: it would be better to find some semantic names (if possible) and leave it to the frontend to do the layout. For instance, if we're talking about annotation, Company users can choose between two ways of alignment, at least. And with 'kind' icons, some users will prefer them on the left, and some (even though there is currently no such option) would prefer it on the right. The current examples of affixation function usages are quite modest: one can be turned into an annotation, and the other into a "kind" icon. Perhaps the annotation placement hint for the former example might make sense, but I wouldn't call it crucial.