From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type. Date: Wed, 10 Jul 2024 10:24:10 -0700 Message-ID: <8b88d2f3-b0dc-6307-480d-0bdbb0664c68@gmail.com> References: <172054273136.24557.15429439759711990393@vcs2.savannah.gnu.org> <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org> <877cdua4ur.fsf@gmail.com> <811B0DE0-5514-436F-9D95-8F6294FB4909@gmail.com> <8734ohaa9m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7461"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Robert Pluim , =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 10 19:24:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRb3q-0001mD-Ny for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jul 2024 19:24:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRb3E-0005tL-Hm; Wed, 10 Jul 2024 13:24:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRb3C-0005sx-GO for emacs-devel@gnu.org; Wed, 10 Jul 2024 13:24:18 -0400 Original-Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRb3B-0004i2-1g for emacs-devel@gnu.org; Wed, 10 Jul 2024 13:24:18 -0400 Original-Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-75cda3719efso3419282a12.3 for ; Wed, 10 Jul 2024 10:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720632255; x=1721237055; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=g5OaIv2vnGEpBqHSnby95B9tNkfa1lMeR5lsX92W+jo=; b=HAaDp+dghuqPXFOOn7VEptdTXJFaKBBg3hR78ISsXPgKHxR5avHyhaduCrrYnP7kKu OulD5diJjy/jHg+3x+e/Ap+o1G+8JUsQE2wjJ9tA+mei6N9RdmQRsSoIYm7AwaK70E3i KUtTtyiU4wz1m02aQVWLDY7v4G2yY195QoJdCqoTdtnYYU5m1tLXxgTUhvFAeF54T/PZ o5tV1yk1hvqEQx7m0PmwoHCOok7fw2L5adg94QzY5Q9RRjwsD7AxHwA2FZ/z0L0zK7yG rlOYO99Y/GesFg3553Sc6eyrYFgGt1XieTvXRJMxlMd3YWL+5ZWU1dgWi3i9VU5emuMO ceyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720632255; x=1721237055; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g5OaIv2vnGEpBqHSnby95B9tNkfa1lMeR5lsX92W+jo=; b=Q6c0LoJJ85WVIZpbh3heqwXp56pnkcYh+9pszuwf0T4+JLOQjofPYg51+Sa0j5t46U lQ65LgpDRveb1morEle2s8VLFeJmv05uRRVIP2WhNH87y6pOC+uUtJlSaQtxR+yHyswm /Aes4vabJHM/fu4DM12dL9HRbjYe4d1nFdBaqtOC7Hgz8nzVYaTqUhmmKHQ0CtQUEQ1K usW2qsYo6rxx96wRq93KBwbH8VvUUpMfhq6NWt+6xZJE9DlFtHmrYtxdDx3N/oksVYqU XDErQqmV24iCgh3bElY1wLW1g6vpoGHww4eMRcV0X4ZlszPOb7hbzaWXac5qonsC5Ibg 5rAg== X-Gm-Message-State: AOJu0Yz6Y4uRLpbl45Isc33uKrfTbssT+PhnZjkT3d77pAAg3nTDYALj tGlFhtKKi4IP1y2rGpghksBplWvK6yvjMImNT8hSxZUYW69kFZs6 X-Google-Smtp-Source: AGHT+IE1F7cEuRYu7uJRreZe7KJ/UjaoB/+jJM7twxOFj2y5Re7FT1ZHS9A3rww9km2BZoRBA3f5HQ== X-Received: by 2002:a05:6a20:734c:b0:1c1:a25c:745e with SMTP id adf61e73a8af0-1c2982233d8mr7334652637.17.1720632255432; Wed, 10 Jul 2024 10:24:15 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fbb6a0fbf0sm36251225ad.21.2024.07.10.10.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 10:24:15 -0700 (PDT) Content-Language: en-US In-Reply-To: <8734ohaa9m.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321579 Archived-At: On 7/10/2024 2:04 AM, Robert Pluim wrote: > The type agrees with the value, but not the documentation: > > Each element > can be one of the following symbols: [snip] > The current type lets you choose to enable each option, but not to > reorder them without resorting to lisp code. Ultimately, I'm more interested in ensuring the list has no duplicate elements than in allowing reordering (the code would behave strangely with duplicate elements), but if we got both that would certainly be nice. If we had to choose one or the other though, I think the current type (thanks Mattias!) is the way to go.