From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: pull requests Date: Fri, 27 Mar 2020 10:37:38 -0400 Message-ID: <8b7d5a28-8193-cd12-bb47-b70c7eee6db5@gmail.com> References: <87mu87ji39.fsf@dick> <87v9mvp2ms.fsf@blind.guru> <87d093f6lj.fsf@dick> <87369yc79r.fsf@dick> <83mu828c7d.fsf@gnu.org> <7b0e82fd-8928-26d2-4bed-331593685f36@gmail.com> <83h7ya7wne.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 27 15:38:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHq7k-000W2p-Et for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Mar 2020 15:38:16 +0100 Original-Received: from localhost ([::1]:42548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHq7j-0003PG-Iv for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Mar 2020 10:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39817) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHq7D-0002wO-UC for emacs-devel@gnu.org; Fri, 27 Mar 2020 10:37:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHq7C-0006XH-Ea for emacs-devel@gnu.org; Fri, 27 Mar 2020 10:37:43 -0400 Original-Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:43954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHq7C-0006RS-AK; Fri, 27 Mar 2020 10:37:42 -0400 Original-Received: by mail-qk1-x732.google.com with SMTP id o10so10927181qki.10; Fri, 27 Mar 2020 07:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=udECKp31HIiqVsGZj7uFgDwkaILst7OHgDiVuEoowAA=; b=bP4VgJZotFeyTiKDkmWPgNRcq7UDhywEdsrOx9IVJRXmP8lbOv/Uecy0Jh/PJObswQ dCNt3QDe3YsBBDNqho+IR0758UsbV4lL8ZDkze/TBhEV9bIUfH+Ujirr+eaHcwENVaUb ptcv8H1OQ3pwlSxgyIytY6mYXN4bGuUk4k3InB3yqu/ABdKmJE3mmK2u5hjWpFWOSZKc CzngDqk9/lGvbc9W2IzY9NklFHmYO7kCENLTpg9BmtP/YbajlJ4xHwX5dSa46BDU0SUk CEq8cViSmI/o7doaiRWcJLsTJmQdoJPQtiFtklL7entKuIzF6/u7LtuS93Y+wF7aV7nO jR+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=udECKp31HIiqVsGZj7uFgDwkaILst7OHgDiVuEoowAA=; b=Bz2d5BEkJdxnN5+pbQs+D6XKWynwDE+7dj1pfihq9flqUSTbcvsFzVmPN62w0UBK2N woiL1gHJ0dhnxpFww3FrynP3peczHFchxEJaYaJO/sskYWc30DtIdTlW/2pHrAEJZTa6 Lrypi2u9GV6xuS7QYF5Voz1ZJt9RFLCzSYWORFaS4duYYSf71sUWpi8pYS0msU9p+a1M K5Igx3u+ccjz0DZdGfp601R7ssmjQyzDEQI9pkmQDCrfOKVidYBGh1G/OdPyPz4YRFp5 2sSRbYN37h8VENG1Z3QoL2Kk4NpHV3l5fSBnYhz4hxKmp7qM7Vb5KyRU1kriO7ID63V7 ouJA== X-Gm-Message-State: ANhLgQ2TT4JysNLw5LYiNbv/7AHnNGaIpz4KQSXeFzfvRZXhLjDo0zON hfvHBDlRcAmx8vyuNZHXThsmGq8v X-Google-Smtp-Source: ADFU+vtZDqhRfI9nSwThfk3AMSBksJX+pxTDHdQHYmOkxxhovpJvXVm4LDDErdySnG9L18+ucbQN5g== X-Received: by 2002:a37:9d8f:: with SMTP id g137mr13715993qke.133.1585319860646; Fri, 27 Mar 2020 07:37:40 -0700 (PDT) Original-Received: from ?IPv6:2601:184:4180:66e7:518c:7d7c:3f2e:efe8? ([2601:184:4180:66e7:518c:7d7c:3f2e:efe8]) by smtp.googlemail.com with ESMTPSA id v187sm3807672qkc.29.2020.03.27.07.37.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2020 07:37:40 -0700 (PDT) In-Reply-To: <83h7ya7wne.fsf@gnu.org> Content-Language: en-GB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::732 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245839 Archived-At: On 27/03/2020 09.30, Eli Zaretskii wrote: >> From: Clément Pit-Claudel >> Date: Fri, 27 Mar 2020 09:00:10 -0400 >> >> On 27/03/2020 03.54, Eli Zaretskii wrote: >>> More importantly, given that I did a review >>> of such a remote branch, how do I communicate my comments so that they >>> are recorded for posterity? Probably by email, so that doesn't seem >>> to solve the main problem of avoiding email in the patch submission >>> and review workflow. >> >> Assuming you use the web UI, you can typically attach comments to code regions. > > And how does one point to such past discussions, or more generally > make sure they end up in some centralized place we could later > revisit? These comments survive even after the pull request is merged, so the tracker that hosted the discussion and the code comments acts as that centralized place. Here is a good example, from GTK, which moved to gitlab a while ago with the rest of Gnome: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1158 (gitlab calls them "merge requests") On that page you can see many sections that say `… started a thread on an outdated change`. This means that a project maintainer (or anyone, really) commented on part of the patch, then the original patch author (or anyone able to push to the corresponding branch) updated the code (hence the "outdated" part — but note that the diff under discussion is still available). The part that says `Resolved by … 4 months ago' means that the author or the original commenter indicated that the particular point under discussion had been resoled, so that discussion is now hidden by default to reduce noise. Here is another example, from nautilus: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/417. In both cases the changes have been applied to the master branch ("merged"), but the discussion persists in the tracker. HTH, Clément.