From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: pull requests
Date: Fri, 27 Mar 2020 10:37:38 -0400 [thread overview]
Message-ID: <8b7d5a28-8193-cd12-bb47-b70c7eee6db5@gmail.com> (raw)
In-Reply-To: <83h7ya7wne.fsf@gnu.org>
On 27/03/2020 09.30, Eli Zaretskii wrote:
>> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
>> Date: Fri, 27 Mar 2020 09:00:10 -0400
>>
>> On 27/03/2020 03.54, Eli Zaretskii wrote:
>>> More importantly, given that I did a review
>>> of such a remote branch, how do I communicate my comments so that they
>>> are recorded for posterity? Probably by email, so that doesn't seem
>>> to solve the main problem of avoiding email in the patch submission
>>> and review workflow.
>>
>> Assuming you use the web UI, you can typically attach comments to code regions.
>
> And how does one point to such past discussions, or more generally
> make sure they end up in some centralized place we could later
> revisit?
These comments survive even after the pull request is merged, so the tracker that hosted the discussion and the code comments acts as that centralized place.
Here is a good example, from GTK, which moved to gitlab a while ago with the rest of Gnome: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1158 (gitlab calls them "merge requests")
On that page you can see many sections that say `… started a thread on an outdated change`. This means that a project maintainer (or anyone, really) commented on part of the patch, then the original patch author (or anyone able to push to the corresponding branch) updated the code (hence the "outdated" part — but note that the diff under discussion is still available). The part that says `Resolved by … 4 months ago' means that the author or the original commenter indicated that the particular point under discussion had been resoled, so that discussion is now hidden by default to reduce noise.
Here is another example, from nautilus: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/417. In both cases the changes have been applied to the master branch ("merged"), but the discussion persists in the tracker.
HTH,
Clément.
next prev parent reply other threads:[~2020-03-27 14:37 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 22:35 ELPA: where is chess developed? Jack Hill
2020-03-23 4:26 ` John Wiegley
2020-03-23 13:50 ` dick.r.chiang
2020-03-23 14:27 ` Mario Lang
2020-03-23 15:12 ` dick.r.chiang
2020-03-24 8:10 ` Philippe Vaucher
2020-03-24 11:38 ` dick.r.chiang
2020-03-24 11:54 ` Philippe Vaucher
2020-03-24 14:12 ` Stefan Monnier
2020-03-24 14:41 ` Stefan Monnier
2020-03-27 2:59 ` pull requests Richard Stallman
2020-03-27 3:49 ` Stefan Monnier
2020-03-28 2:45 ` Richard Stallman
2020-03-28 3:03 ` Stefan Monnier
2020-03-27 7:54 ` Eli Zaretskii
2020-03-27 13:00 ` Clément Pit-Claudel
2020-03-27 13:30 ` Eli Zaretskii
2020-03-27 14:37 ` Clément Pit-Claudel [this message]
2020-03-27 15:21 ` Eli Zaretskii
2020-03-27 15:41 ` Dmitry Gutov
2020-03-27 19:16 ` Eli Zaretskii
2020-03-27 19:24 ` Dmitry Gutov
2020-03-27 19:34 ` 조성빈
2020-03-27 19:28 ` Eli Zaretskii
2020-03-27 20:39 ` Dmitry Gutov
2020-03-28 2:46 ` Richard Stallman
2020-03-28 17:14 ` Dmitry Gutov
2020-03-30 3:38 ` Richard Stallman
2020-03-30 4:09 ` Stefan Monnier
2020-03-30 5:58 ` Eli Zaretskii
2020-03-30 12:03 ` Dmitry Gutov
2020-03-30 12:55 ` Yuri Khan
2020-03-30 13:12 ` Eli Zaretskii
2020-03-30 13:50 ` Dmitry Gutov
2020-03-30 14:12 ` Eli Zaretskii
2020-03-30 14:34 ` Dmitry Gutov
2020-03-30 15:36 ` Eli Zaretskii
2020-03-30 15:50 ` Dmitry Gutov
2020-03-30 16:09 ` Eli Zaretskii
2020-03-30 17:06 ` Dmitry Gutov
2020-03-30 17:13 ` Eli Zaretskii
2020-04-02 2:39 ` Richard Stallman
2020-04-17 3:54 ` Dmitry Gutov
2020-03-30 13:43 ` Stefan Monnier
2020-03-30 16:59 ` Dmitry Gutov
2020-03-30 17:20 ` Stefan Monnier
2020-03-30 17:28 ` Dmitry Gutov
2020-03-30 8:25 ` 조성빈
2020-03-30 11:51 ` Dmitry Gutov
2020-03-30 13:04 ` Eli Zaretskii
2020-03-30 17:49 ` Dmitry Gutov
2020-03-27 16:39 ` Clément Pit-Claudel
2020-03-27 19:21 ` Eli Zaretskii
2020-03-27 14:05 ` Stefan Monnier
2020-03-28 2:46 ` Richard Stallman
2020-03-23 15:58 ` ELPA: where is chess developed? Stefan Monnier
2020-03-23 14:25 ` Mario Lang
-- strict thread matches above, loose matches on Subject: below --
2020-04-17 4:24 pull requests Zach Pearson
2020-04-17 8:11 ` Alex Ott
2020-04-17 16:36 ` Dmitry Gutov
2020-04-21 1:47 ` Richard Stallman
2020-04-21 2:12 ` Po Lu
2020-04-22 3:19 ` Richard Stallman
2020-04-23 3:15 ` Po Lu
2020-04-17 16:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b7d5a28-8193-cd12-bb47-b70c7eee6db5@gmail.com \
--to=cpitclaudel@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).