* Re: emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142)
[not found] ` <20230206064515.5AA2CC0060F@vcs2.savannah.gnu.org>
@ 2023-02-06 22:15 ` Dmitry Gutov
2023-02-07 2:52 ` Yuan Fu
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Gutov @ 2023-02-06 22:15 UTC (permalink / raw)
To: emacs-devel, Theodor Thornhill
Hi Theodor,
On 06/02/2023 08:45, Theodor Thornhill via Mailing list for Emacs
changes wrote:
> + (equal (treesit-node-type node) c-ts-common-if-statement-regexp)
> + (equal (treesit-node-type (treesit-node-parent node))
> + c-ts-common-if-statement-regexp)
If the variable is called -regexp, I suppose these should use
string-match-p.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142)
2023-02-06 22:15 ` emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142) Dmitry Gutov
@ 2023-02-07 2:52 ` Yuan Fu
0 siblings, 0 replies; 2+ messages in thread
From: Yuan Fu @ 2023-02-07 2:52 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel, Theodor Thornhill
> On Feb 6, 2023, at 2:15 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> Hi Theodor,
>
> On 06/02/2023 08:45, Theodor Thornhill via Mailing list for Emacs changes wrote:
>> + (equal (treesit-node-type node) c-ts-common-if-statement-regexp)
>> + (equal (treesit-node-type (treesit-node-parent node))
>> + c-ts-common-if-statement-regexp)
>
> If the variable is called -regexp, I suppose these should use string-match-p.
>
I partly am to blame. I made some changes to c-ts-common but didn’t push it, so Theo had to patch on my convoluted code. I’ve pushed my changes and updated java-ts-mode to use the new interface. This new interface is hopefully easier to use and understand.
Yuan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-07 2:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <167566591126.8500.18117950634798405754@vcs2.savannah.gnu.org>
[not found] ` <20230206064515.5AA2CC0060F@vcs2.savannah.gnu.org>
2023-02-06 22:15 ` emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142) Dmitry Gutov
2023-02-07 2:52 ` Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).