unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Mendler <mail@daniel-mendler.de>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: Simplification of `affixation-function`
Date: Sun, 25 Apr 2021 00:01:01 +0200	[thread overview]
Message-ID: <8b57f857-d530-ca31-5ac0-6526cda3f927@daniel-mendler.de> (raw)
In-Reply-To: <878s575pis.fsf@mail.linkov.net>

On 4/24/21 11:41 PM, Juri Linkov wrote:> We could just change the 
documentation of ‘affixation-function’ to define
> only one supported way of using the “completion + prefix + suffix” format
> to reduce confusion.

This is a "resolution" I would not be happy with. We still keep around 
an obsolete format (which has only been introduced a few months ago) and 
then keep it out of the documentation. I think it is preferable to 
correct the definition then.

But it is okay to keep the current definition if you think the costs of 
a change outweigh the benefits.

 > I'd prefer to support additional text using keywords, e.g.
 > ("completion" "prefix" "suffix" :help "Help text")

The suggestion with the keywords is nice. If you plan to allow such 
additional keywords, this should be documented then, since completion 
UIs rely on the documentation when they implement support for the 
function. Which formats will be allowed? We already have `(candidate 
suffix)` and `(candidate prefix suffix)`.

For extensibility one may want to add

(candidate :prefix prefix :suffix suffix :other-keys...)

or as you proposed

(candidate prefix suffix :other-keys...).

Daniel



  reply	other threads:[~2021-04-24 22:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 17:35 Simplification of `affixation-function` Daniel Mendler
2021-04-24 20:22 ` Juri Linkov
2021-04-24 21:17   ` Daniel Mendler
2021-04-24 21:41     ` Juri Linkov
2021-04-24 22:01       ` Daniel Mendler [this message]
2021-04-24 22:34   ` Stefan Monnier
2021-04-24 22:48     ` Dmitry Gutov
2021-04-24 22:56       ` Daniel Mendler
2021-04-25 17:58         ` Dmitry Gutov
2021-04-25 18:08           ` Daniel Mendler
2021-04-25 22:31             ` Dmitry Gutov
2021-04-27 16:48               ` Juri Linkov
2021-04-27 17:39                 ` Daniel Mendler
2021-04-27 18:11                   ` Juri Linkov
2021-04-27 18:40                     ` Daniel Mendler
2021-04-28  0:20                 ` Dmitry Gutov
2021-04-28 19:59                   ` Juri Linkov
2021-04-29  2:15                     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b57f857-d530-ca31-5ac0-6526cda3f927@daniel-mendler.de \
    --to=mail@daniel-mendler.de \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).