From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116) Date: Sat, 3 Aug 2024 00:30:19 -0700 Message-ID: <8F99C2F8-F88E-4662-B2E8-70592DBAEAC8@gmail.com> References: <172238461549.32268.17283604138559769854@vcs2.savannah.gnu.org> <20240731001020.DEFADC1CAE9@vcs2.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11961"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 03 09:31:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sa9ET-00030M-RF for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Aug 2024 09:31:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sa9Dp-0008Ro-K3; Sat, 03 Aug 2024 03:30:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sa9Dn-0008Rc-W5 for emacs-devel@gnu.org; Sat, 03 Aug 2024 03:30:36 -0400 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sa9Dm-0006yy-Ch; Sat, 03 Aug 2024 03:30:35 -0400 Original-Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1fd70ba6a15so69554015ad.0; Sat, 03 Aug 2024 00:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722670231; x=1723275031; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZjjqXV6r1inyrYDDQ82280IEsi1QkY2OFgNwqEFrr1w=; b=cAtiPupeGq3plQP4P0bTH5pxCTjQsWqC5fJ/4Xz/uLIRAXLl5PFw749WxdQFFCVO6q tqMoPUwVmLrCFOxgVWQ5NVKDCRGJn7lfbFaDB8V8SC89fFc8Wj/hyUf/du/rjWcu7nHR VjETCs3nA93gVvznRF1K5TGmMup4VZwKBNXYbjib9brI7tecc+ECKrWnXDEZHvFgiWdx l+infQfgT5IgYK73WJw7XF8MTmUADCnkjQaXRAXQBhERWoo5UO2EAxf0SbBzFDxXtFmQ 5mxBKQud5T2Rcx6qTPdYReDRzAqY+IlVVO3p4l8G3XzW6a+xI6UwJtIPAmuEktPm8z2k tcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722670231; x=1723275031; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZjjqXV6r1inyrYDDQ82280IEsi1QkY2OFgNwqEFrr1w=; b=ElogYnUxQgpESv0ntKwapyB8LzCC0DFjC4lgiAriPAlPkjZ/+xBK1GuOneYcmZ3/y4 GdsGI6pvODhhXjWl+DydMoOPB7KjPiUdBrFN7f+6rwNH9FqkEjt6VSoKQQxZtuL6ZxMz 3clywGD2gRT5w6yMoe3uTLX1zkCTr5AL16QlmPZBqfY0xaxq0HAxYVOMuJBE3YW4wBWh Kdho2WRrBQ04h2igAxWbA/XShQQdSLYMyF5nfzyl/kRi8xdMN90kaz1yMmtYNjknCNSQ yYLAW0tFq23S3fr9312UM6NQHltQ9ijLK6lKXBzRxo/MI3NQc10X+jIUB8meuTRnQB5t whuQ== X-Gm-Message-State: AOJu0YwW1kiO1ShY0ur4R3uJZJVB6eK8OFkMA6EsgOjCvX+sBmZ76xSO vC6pMlQyjhfP3G9eorGQDp4jLQ5EEH8WKI/Qh4z4cQ7xjbUbA9HdIvie0A== X-Google-Smtp-Source: AGHT+IFAEL5d9i7B6ZXYaFyBvtqtRXXGtbXHTA14+rfvH+UvCF9LmETzNMZw0vefIh1zVNNnntzZzg== X-Received: by 2002:a17:902:f68c:b0:1fd:668b:ac4b with SMTP id d9443c01a7336-1ff5725902emr76642795ad.15.1722670230984; Sat, 03 Aug 2024 00:30:30 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:fc55:48f9:5161:d744]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff58f29d2bsm28588765ad.7.2024.08.03.00.30.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Aug 2024 00:30:30 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3774.600.62) Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=casouri@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322295 Archived-At: > On Aug 1, 2024, at 1:53=E2=80=AFAM, Andrea Corallo = wrote: >=20 > Yuan Fu writes: >=20 >> branch: master >> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f >> Author: Yuan Fu >> Commit: Yuan Fu >>=20 >> Fix filling in c-ts-mode (bug#72116) >>=20 >> The previous fix introduced a regression in the case when there's = only a >> single line in the block comment. In that case we don't want to = add a >> start at the second line: >>=20 >> /* foo foo foo */ should =3D> /* foo foo >> foo */ >>=20 >> rather than /* foo foo >> * foo */ >>=20 >> This commit fixes that. >>=20 >> * lisp/progmodes/c-ts-common.el: >> (c-ts-common--fill-block-comment): Don't mask the /*. >> (c-ts-common--adaptive-fill-prefix): New function. >> (c-ts-common-comment-setup): Don't set adaptive-regexp, change >> adaptive-fill-first-line-regexp to work with the new >> adaptive-fill-function. >> * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests >=20 > Hi Yuan, >=20 > this change is causing the following regression on my testbench on > master: >=20 > c-ts-mode-test-filling > 1/4 c-ts-mode-test-filling (0.015896 sec) at = lisp/progmodes/c-ts-mode-tests.el:38 >=20 > Would you mind having a look? >=20 > Thanks Yes absolutely, wonder why it didn=E2=80=99t error when I wrote the = patch :-( Yuan=