From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org, Tom Gillespie <tgbugs@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: [PATCH] hack-one-local-variable use lexical-binding
Date: Thu, 26 Nov 2020 09:16:45 +0200 [thread overview]
Message-ID: <8E2B73D4-1269-4D0A-B572-7B6B47C46924@gnu.org> (raw)
In-Reply-To: <CA+G3_PPS947dV3i-su2RTNxzKpZv5Zqt8QaeAiEJf+tHHmwp_A@mail.gmail.com>
On November 26, 2020 6:47:44 AM GMT+02:00, Tom Gillespie <tgbugs@gmail.com> wrote:
> > I think we should just always pass `t` to `eval` there, yes.
> > The other option is over-engineered.
>
> Agreed. Here is the updated patch. I'm guessing this will need a NEWS
> item?
This would be a backward-incompatible change, wouldn't it? I'd prefer a backward compatible solution. For example, how about a separate lexical-eval clause, which will do this leaving eval to work as it did before?
And yeas a NEWS item is necessary regardless.
Thanks.
next prev parent reply other threads:[~2020-11-26 7:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 2:55 [PATCH] hack-one-local-variable use lexical-binding Tom Gillespie
2020-11-26 3:07 ` Stefan Monnier
2020-11-26 4:47 ` Tom Gillespie
2020-11-26 7:16 ` Eli Zaretskii [this message]
2020-11-26 14:21 ` Stefan Monnier
2020-11-26 14:44 ` Eli Zaretskii
2020-11-29 4:12 ` Tom Gillespie
2020-11-29 9:43 ` Stefan Kangas
2020-11-29 15:42 ` Eli Zaretskii
2020-11-29 19:50 ` Tom Gillespie
2020-11-29 20:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8E2B73D4-1269-4D0A-B572-7B6B47C46924@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).