unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Sharman <rsharman@pobox.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu@gmail.com>,
	martin rudalics <rudalics@gmx.at>,
	Emacs Devel <emacs-devel@gnu.org>, Richard Stallman <rms@gnu.org>,
	Richard Sharman <rsharman@pobox.com>
Subject: Re: patch to hilight-chg not in emacs 22.1
Date: Mon, 17 Mar 2008 23:11:37 -0400	[thread overview]
Message-ID: <8CB2E924-9CF1-4312-911C-1DA4783D19FD@pobox.com> (raw)
In-Reply-To: <jwv8x0ha1i8.fsf-monnier+emacs@gnu.org>

Hi Stefan.

>> So,  I have simplified the change to hilit-chg.el and have removed  
>> the part
>> that required the change to easy-mmode.  (I think what I was   
>> previously
>> doing was overkill anyway.)
>
> Thank you, this looks good.  I'd only advise you to rename
> highlight-changes-toggle-visibility to highlight-changes-visible-mode
> and define it (yet again) with define-minor-mode.

So, if I understand it,  you are suggesting having two minor modes:   
highlight-changes-mode and highlight-changes-visible-mode?  Isn't  
that going to be a bit confusing??

If highlight-changes-mode were on then the meaning of the new mode is  
straight forward,  but if it were off should it just toggle the flag  
and otherwise have no effect?  So it affects highlight changes mode  
either immediately if that mode is on otherwise the next time it is  
turned on?  I can try and it see what it's like.

Do other people think that's the way to go?

Richard






  reply	other threads:[~2008-03-18  3:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-16 17:52 patch to hilight-chg not in emacs 22.1 Richard Sharman
2008-03-17 14:11 ` Stefan Monnier
2008-03-18  3:11   ` Richard Sharman [this message]
2008-03-18 16:51     ` Stefan Monnier
2008-03-19  2:43       ` Richard Sharman
2008-03-19 16:20         ` Stefan Monnier
2008-04-25 14:27           ` Juanma Barranquero
2008-05-02  3:21             ` Richard Sharman
2008-05-02  8:53               ` Juanma Barranquero
2008-03-18  9:55 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CB2E924-9CF1-4312-911C-1DA4783D19FD@pobox.com \
    --to=rsharman@pobox.com \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).