From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: :extend t inheritance Date: Sun, 27 Oct 2019 12:01:04 +0100 Message-ID: <8A6372EC-EF24-42B7-9E0C-E49BC98C6931@aol.com> References: <87zhhrmcaq.fsf@kenko.localhost.com> <83o8y6xnmn.fsf@gnu.org> <20191026014911.7riwc5oq6epjhdiq@Ergus> <8336fgvuby.fsf@gnu.org> <357181555.902089.1572117701015@mail.yahoo.com> <83ftjfthnj.fsf@gnu.org> <453335474.949467.1572131620451@mail.yahoo.com> <831ruyu46s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----OU3EA01OEURBMSXPMOW1ABN9BOBV3Y" Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86449"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android Cc: ingo.lohmar@posteo.net,emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 12:04:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOgL5-000MJn-7t for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 12:04:03 +0100 Original-Received: from localhost ([::1]:44854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOgL3-0008RD-45 for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 07:04:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49110) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOgKI-0008R1-Rm for emacs-devel@gnu.org; Sun, 27 Oct 2019 07:03:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOgKH-0004qs-DK for emacs-devel@gnu.org; Sun, 27 Oct 2019 07:03:14 -0400 Original-Received: from sonic317-55.consmr.mail.bf2.yahoo.com ([74.6.129.110]:45773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOgKH-0004qF-9k for emacs-devel@gnu.org; Sun, 27 Oct 2019 07:03:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1572174191; bh=EuwFTr7pHXip1/ZuayVTGhnmzO0mqEp7mcRIlaUxJKY=; h=Date:In-Reply-To:References:Subject:To:From:From:Subject; b=KAg2q8u71SnyUR6nvA0OOjPTaj5JWwhTTHnWDMJwtCit7OQTJxzcTZappfWsg2+D58Cv0Y+FgkfENtChXm2IAz/Jl2kyRCcspMvh76CY08RaXQUT1ORa+zgwKVyOazyAlT5wWdNEqO/rvqyP0ylGq0fdodD3YAvoYuFkV3vd0THpW2Pi3gBr9gGWkj+wgYILFq3CFVdfI5m9MqU0WolgZa9E6bPiz556tZva7oaATGiM3LnyU3DSqBy9J68Q9gsRSboGP7lQ6L81+2szcRQcLRoaENR7RStPfpiQxSe2gvuOPRpgJUN6gA7CuRXebr78s9eMYY0ALolk95AEidQORQ== X-YMail-OSG: N_6BpMEVRDvd.miR6A7lED5GPdAEx7ojsA-- Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.bf2.yahoo.com with HTTP; Sun, 27 Oct 2019 11:03:11 +0000 Original-Received: by smtp401.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID a2bfecf0657045c29002e4219d7ba8bd; Sun, 27 Oct 2019 11:01:10 +0000 (UTC) In-Reply-To: <831ruyu46s.fsf@gnu.org> X-Mailer: WebService/1.1.14593 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.6.129.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241511 Archived-At: ------OU3EA01OEURBMSXPMOW1ABN9BOBV3Y Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable In GUI=2E The issue was in GUI=2E What I said about tui was that I didn't o= bserve the issue in tui=2E=20 On October 27, 2019 6:51:07 AM GMT+01:00, Eli Zaretskii w= rote: >> Date: Sat, 26 Oct 2019 23:13:40 +0000 (UTC) >> From: Ergus >> Cc: ingo=2Elohmar@posteo=2Enet, emacs-devel@gnu=2Eorg >>=20 >> Ohh right, that's the other commit=2E When fixing this issue I found >another error I didn't see in tui=2E After EOL we >> need to fill with the merged filtered face=2E To do that we need to add >a stretch glyph; but we were just adding a >> normal glyph with a ' ' so the face was not really extended, just the >background color because the X display >> engine always do that=2E But, for example, underline was not extended= =2E >This commit fixes just that=2E >> stretch_ascent was moved out of the if(column_indicator) because the >new stretch_glyphs needs it any way >> and the two comments were 1) for old moved code not there anymore and >2) to describe the situation of the >> glyphs color extension (mention in previous paragraph) that we don't >need to work around anymore because >> the glyph fills the entire screen now=2E=2E=20 > >I'm still a bit confused: was the problem you found happening in GUI >frames or in text-mode frames? You say "tui", but then talk about >something X does=2E=2E=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------OU3EA01OEURBMSXPMOW1ABN9BOBV3Y Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable In GUI=2E The issue was in GUI=2E What I said abou= t tui was that I didn't observe the issue in tui=2E

On October 27, 2019 6:51:07 AM GMT+01:00, Eli Zaretskii <eli= z@gnu=2Eorg> wrote:
Dat=
e: Sat, 26 Oct 2019 23:13:40 +0000 (UTC)
From: Ergus <spacibba@aol=2E=
com>
Cc: ingo=2Elohmar@posteo=2Enet, emacs-devel@gnu=2Eorg

Ohh=
 right, that's the other commit=2E When fixing this issue I found another e=
rror I didn't see in tui=2E After EOL we
need to fill with the merged fi=
ltered face=2E To do that we need to add a stretch glyph; but we were just =
adding a
normal glyph with a ' ' so the face was not really extended, ju=
st the background color because the X display
engine always do that=2E B=
ut, for example, underline was not extended=2E This commit fixes just that=
=2E
stretch_ascent was moved out of the if(column_indicator) because the=
 new stretch_glyphs needs it any way
and the two comments were 1) for ol=
d moved code not there anymore and 2) to describe the situation of the
g=
lyphs color extension (mention in previous paragraph) that we don't need to=
 work around anymore because
the glyph fills the entire screen now=2E=2E=
 

I'm still a bit confused: was the problem you found h=
appening in GUI
frames or in text-mode frames?  You say "tui", but then =
talk about
something X does=2E=2E=2E

-- =
Sent from my Android device with K-9 Mail=2E Please excuse my brevity= =2E ------OU3EA01OEURBMSXPMOW1ABN9BOBV3Y--