From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Fri, 28 Oct 2022 18:23:47 +0200 Message-ID: <8A4945F1-51AD-4BC5-ABC4-E189DA670C67@thornhill.no> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25293"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?ISO-8859-1?Q?Jo=E3o_Paulo_Labegalini_de_Carvalho?= To: emacs-devel@gnu.org, Stefan Monnier , Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 18:25:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooSAk-0006Jf-Hy for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 18:25:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooS9a-00054X-Io; Fri, 28 Oct 2022 12:24:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooS9U-00054I-WB for emacs-devel@gnu.org; Fri, 28 Oct 2022 12:24:16 -0400 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooS9S-00025p-Pk for emacs-devel@gnu.org; Fri, 28 Oct 2022 12:24:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1666974246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RFZXMHbwd1vLdjQX/WJ2JWlOzfNInXGAFoyQPwS0zAk=; b=ekiNh09st3BCvaL9u+4Eu6xsOSlCBdJncG99VDOy22iVn1uVgEDU3XayFeI1nDZcN7P7u4 LhLvgU1PTtyo2JEhK2F+mz+PX+GJSOJw3O1WpxDcsWOFvymM7uTXc7Tkh+O5pYW28SrQal re2UM9ttUHGq2OzYB9QKis68DDcr8xamPE/BUXfcpI1/vmx7QW1QYQ2GILvpworZjDxKAO 4dUZAqElfzhu0l0527TIaTexrzojTbg3yIl8iABF8YLJ6PmJyej41GT2NYnEC9OHXQ74Ck uD0bbVkyRLJ+2avWtzTKifHLStbBVN9QLqU+YasZClwn2SvJv7yAQJYnnnfbhg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298683 Archived-At: On 28 October 2022 18:15:01 CEST, Stefan Monnier wrote: >Stefan Kangas [2022-10-28 08:57:07] wrote: >> Jo=C3=A3o Paulo Labegalini de Carvalho writes: >>> + (setq-local treesit-font-lock-feature-list >>> + '((basic) (moderate) (elaborate))) >> I see that most modes on the branch seem to be using those three symbol= s >> for now=2E > >Indeed, it's sad=2E It's goes against the idea being >`treesit-font-lock-feature-list` which is to map features to levels=2E > >It doesn't make much sense to call a highlight feature "moderate"=2E >Highlight feature names should be things like "function names", "nested >functions", "multiline docstrings", "punctuation"=2E Agreed=2E Sloppy work on my end=2E I'll make a new commit this evening :-)= =20 Theo=20