unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Matthias Meulien <orontee@gmail.com>, emacs-devel@gnu.org
Subject: Re: Is vc-diff-mergebase broken on master?
Date: Tue, 31 Aug 2021 03:00:51 +0300	[thread overview]
Message-ID: <89f53c5f-3936-bfb1-eb47-11c9a6bd8e5c@yandex.ru> (raw)
In-Reply-To: <87a6kyacqn.fsf@gmail.com>

Hi Matthias,

On 30.08.2021 23:39, Matthias Meulien wrote:
> I compiled from a clean Git repository with HEAD pointing to master
> (a1887cc5e6) on both my personal computer and the one I use at work. And
> vc-diff-mergebase is now unusable: Whatever I choose for the older and
> the newer revisions, I get a "No changes between..." messages.
> 
> Am I missing something? I do lots of merge request review and use this
> command on a daily basis, so I suspect a regression has been
> introduced.
> 
> Am I the only one facing troubles with recent master and vc-git?

Thanks for the email. It is unfortunately fallout from bug#39452.

I just pushed commit d2ad64b which seems to fix vc-diff-mergebase, as 
well similar problems that could still remain in any less frequently 
used commands, check it out.

That said, new contributions to vc-tests.el would be quite welcome.

If there was even one test scenario in there that called 
vc-diff-mergebase, we wouldn't have let this bug slip by.



  parent reply	other threads:[~2021-08-31  0:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 20:39 Is vc-diff-mergebase broken on master? Matthias Meulien
2021-08-30 21:48 ` Daniel Martín
2021-08-31  0:00 ` Dmitry Gutov [this message]
2021-08-31  5:55   ` Matthias Meulien
2021-09-02 22:54   ` Matthias Meulien
2021-09-02 23:21     ` Dmitry Gutov
2021-09-04 19:33       ` Matthias Meulien
2021-09-04 20:24         ` Matthias Meulien
2021-09-04 23:50           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89f53c5f-3936-bfb1-eb47-11c9a6bd8e5c@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=orontee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).