From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 77c3d41adc: Prevent text decorations from overwriting surrounding areas on X Date: Tue, 11 Jan 2022 13:18:20 +0000 (UTC) Message-ID: <896262450.1351717.1641907100144@mail.yahoo.com> References: <164181573002.27254.10999604516337949526@vcs2.savannah.gnu.org> <20220110115530.E4B34C0DA1D@vcs2.savannah.gnu.org> <87zgo3pzu3.fsf@yahoo.com> <8335lva3ev.fsf@gnu.org> <87k0f7p0p4.fsf@yahoo.com> <837db68muw.fsf@gnu.org> Reply-To: luangruo@yahoo.com Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1351716_9142457.1641907100143" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 15:16:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7HwT-0006HM-IY for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 15:16:05 +0100 Original-Received: from localhost ([::1]:55900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7HwS-0002Bg-G7 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 09:16:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7H2g-0000ff-7H for emacs-devel@gnu.org; Tue, 11 Jan 2022 08:18:28 -0500 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:32831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7H2e-0000N5-Fh for emacs-devel@gnu.org; Tue, 11 Jan 2022 08:18:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641907103; bh=ZwYfManymitlc/S59wYiwyPMzIHPZirzQuFGz1nAnNU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=Y8Hs7CWJ59JWw4+V/LMRTKYsKi5g8iEiFOvlfToDzmueZY3ydU561sv1CyjREI1NKJcOMwu2WnXK9uWkJut/ZH9cGlUhgUpDyz1FA9IMjBiMBvfKXr3x2C0PngmCfhroiMGM9EyYTzn+od5Zwms1m2siQAva0gN84EaLRf6Zg2+GV9caleN7ZZvW07Niq2icPG20jhsGI17nkncI2Gg+bFQ2Ez6c8wMTmur/Zdy58KEzxg3/ui5baSMSXijCuk1E6RiM6OgaNqoYvVKcM7kbMQ9L5/ikD3LlI9N+w4PEaRGUsZwV8RJQAPtvZ1C4kCqmUs5Jagukl3spr2ptNnNhLg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641907103; bh=LprQttmpg71VUtXDaAFYbWdyok8t7Alk0xdzIUuXjvs=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=cMzILkvgOWbkbFH6bHdTzJAjuQDhpNH6nE3XGoEzZgeoiuiRmQRZ42lcTVvpDqlx3a8GBIPbcK6b3SlYodWljr0HgY98rS1oZhojHWY0o2nv/70pzyeo0Dat45p0AIbK3FpCtOJNMhEdQCl9vZjdliAJEM6hekXheiKrYksSSr9ZMvmwTQklGD0tANQj6+7mOHo/dxaxeYg1e7IdJqrPhIfbH3qwBgk18DG2KdmijHL0W8+FF07h7PZBUY/jkS+pu/EARqhhLDzvdGDdZ0iZGS8zUAEK9PkANDB/udjwbjA1rthepdPNaw2+sr/fQKULqr6rOOrm1TM+mHbxPiEgeQ== X-YMail-OSG: GR3qroQVM1nlDnrl0jI34GUf03xS6OudnYMwS1iVbTGzrwNu9WYlVqysf5wBuPu 13iRiDvj3DqIhc0tz8llS459Q2B3onkbn3Uwg5GVAj0AbdDHClYdasrp9mMgy1z.67RL30fBvwaD D4n71IxNUSo_8hnR.oINEUW2lechZsKxsrDvGl59yVsLOEr0NJNYyrlCLcUT0PqjDjfkyV5s4VWt C3OhldkcbfuEk0sDgqgFdV7SObmR6l0_l9ecf8xHjS2B1ouROBWMde2F7jAvCuy3yXgMRcJv.mRo dyOG3K9t67zM10zYvGx52QwajMQ.ya0vOiR8kvOyVz1X7JwVqFRI8lzmOTWwNoC9oPsMtsXZE7c. PgkWglfXDBTGQZJiHoLg2TobRMHnzDcuBUZmdJAhOnC2fXuyDl2ImUhXAIQV7WT0O9MQO1.5DnGS hjaM3tHS.ttkBfIvTEqxLe4ow9ZSHqpKEbV1VX0xXpTv7NqzrRdQWwsxf8UJO_ncuUXrBVHnOn9L q5dj5yj7YLuWSf_HT8hqOQS_Ax1dN9hPGW.J5zNni9d2fZDOS6tr15b.StwRZtRJB4YGYLWNN63E LGWxrl7xtcvO6T2BBj1se2zwvMX0_CP7CJDCW5brXikmHOtklggGx.mXo60uOAvnW06kdYS0MGGm iteaZ7AFViLpkE7ccysvXiWoIvO5JESfLlvvH3wujVmwRqqchdmWyPj.mWfFkSyA.KKhLD83v9Fi NyBXgLbyiC7gkV7rXg_0pWICLgxXOjB0C0dqnT8asbqOPaCl9j_zpkWobKEevA3XJzKHHAlVe7ZY J3dXI6k8.DabH5pfTLyxrO.RWu87QDJ8TBu9VKbeRs X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Tue, 11 Jan 2022 13:18:23 +0000 In-Reply-To: <837db68muw.fsf@gnu.org> X-Mailer: WebService/1.1.19551 YMailNodin Received-SPF: pass client-ip=66.163.188.204; envelope-from=luangruo@yahoo.com; helo=sonic311-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284603 Archived-At: ------=_Part_1351716_9142457.1641907100143 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit [Sorry for the webmail, Yahoo SMTP is wedged; I hope Reply All worked and this reaches the list] > I have a problem with this correction, because I don't understand the > need for it. s->width is the width of the glyph string, which is > computed from the glyphs that comprise the glyph string. Those glyphs > were laid out by display_line, which should never add a glyph to a > glyph row if that glyph doesn't fit on the screen. So how come > s->width in your case was too large? Or maybe it's s->x that was > wrong (does the underline start exactly under the first glyph)? > So I suspect that your fix hides a much more serious problem > elsewhere. Please investigate the problem you saw before the change. Thanks, will do. Should I revert this fix? ------=_Part_1351716_9142457.1641907100143 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
[Sorry for the webmail, Yahoo SMTP is wedged; I hope Reply All worked
and this reaches the list]

> I have a problem with this correction, because I don't understand the
> need for it. s->width is the width of the glyph string, which is
> computed from the glyphs that comprise the glyph string. Those glyphs
> were laid out by display_line, which should never add a glyph to a
> glyph row if that glyph doesn't fit on the screen. So how come
> s->width in your case was too large? Or maybe it's s->x that was
> wrong (does the underline start exactly under the first glyph)?

> So I suspect that your fix hides a much more serious problem
> elsewhere. Please investigate the problem you sa w before the change.

Thanks, will do. Should I revert this fix?
------=_Part_1351716_9142457.1641907100143--