unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 77c3d41adc: Prevent text decorations from overwriting surrounding areas on X
Date: Tue, 11 Jan 2022 13:18:20 +0000 (UTC)	[thread overview]
Message-ID: <896262450.1351717.1641907100144@mail.yahoo.com> (raw)
In-Reply-To: <837db68muw.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

 [Sorry for the webmail, Yahoo SMTP is wedged; I hope Reply All worked
and this reaches the list]

> I have a problem with this correction, because I don't understand the
> need for it. s->width is the width of the glyph string, which is
> computed from the glyphs that comprise the glyph string. Those glyphs
> were laid out by display_line, which should never add a glyph to a
> glyph row if that glyph doesn't fit on the screen. So how come
> s->width in your case was too large? Or maybe it's s->x that was
> wrong (does the underline start exactly under the first glyph)?

> So I suspect that your fix hides a much more serious problem
> elsewhere. Please investigate the problem you saw before the change.

Thanks, will do. Should I revert this fix?
  

[-- Attachment #2: Type: text/html, Size: 907 bytes --]

  reply	other threads:[~2022-01-11 13:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164181573002.27254.10999604516337949526@vcs2.savannah.gnu.org>
     [not found] ` <20220110115530.E4B34C0DA1D@vcs2.savannah.gnu.org>
2022-01-10 11:58   ` master 77c3d41adc: Prevent text decorations from overwriting surrounding areas on X Po Lu
2022-01-10 17:47     ` Eli Zaretskii
2022-01-11  0:37       ` Po Lu
2022-01-11 12:42         ` Eli Zaretskii
2022-01-11 13:18           ` Po Lu [this message]
2022-01-11 13:35             ` Eli Zaretskii
2022-01-12  1:56               ` Po Lu
2022-01-12  2:30                 ` Jose Antonio Ortega Ruiz
2022-01-12  3:05                   ` Po Lu
2022-01-12  3:48                     ` Jose Antonio Ortega Ruiz
2022-01-12  3:29                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=896262450.1351717.1641907100144@mail.yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).