From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Make all tree-sitter modes optional Date: Mon, 16 Jan 2023 18:30:26 +0200 Message-ID: <8931214e-b005-1cb1-5dfa-66dcdce4e4b5@yandex.ru> References: <84973.1672843723@hassadar.pretzelnet.org> <83wn62xi3k.fsf@gnu.org> <83o7rexe2n.fsf@gnu.org> <83h6x5xym7.fsf@gnu.org> <83h6wr6gmz.fsf@gnu.org> <87wn5mkjqk.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1418"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: emacs-devel@gnu.org To: Theodor Thornhill , Eli Zaretskii , casouri@gmail.com, monnier@iro.umontreal.ca, larsi@gnus.org, jostein@secure.kjonigsen.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 16 17:31:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHSO7-00009h-WE for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Jan 2023 17:31:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHSNY-000563-N4; Mon, 16 Jan 2023 11:30:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHSNW-00055j-3r for emacs-devel@gnu.org; Mon, 16 Jan 2023 11:30:34 -0500 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHSNT-0002A6-OX; Mon, 16 Jan 2023 11:30:33 -0500 Original-Received: by mail-wm1-x32d.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so2895989wmb.0; Mon, 16 Jan 2023 08:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=4D1nq7sGSBAAfqB4yaoDuJ4Ez6NY2oliK0+zN8mLtLA=; b=olrZ6RlG1HF6mVTVjzLJo8Zh9u3jwJD4gDPneRTW+A+oqrg/P6WaBufSwjRD/W84fW fENUMTQGrwKpEn0i6LXgAW5L9elQeqLQucse6uRGrBIWGIvZ2S5FqD5dRa7ZfvmAUyKD c4F62UIH0xpuZ8eXwnax8jNcgAwaqVvMU2wT9Ugg59IcgkeE5hRiDA6dItI8pGqdWIiV I86bBRB2ZZb0JzUR6mKXXHqEuZCeVWYgR3INhI7uT3Vy3SfczS94y1bqAq9+X9cNAWcn EXI3zO8e5//d8JfeQYOt09rgu2wPBQCcjTHSa9vLDO++5IO71HyEde9v0wOu4AFWPkfC HI+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4D1nq7sGSBAAfqB4yaoDuJ4Ez6NY2oliK0+zN8mLtLA=; b=UHIJ2HT6W3V/2RlTXcSACsSklc+iUx1tMrHho9p0K3yP9tNA7FS1Kuhdqp8zSX3xCZ HK5t7LBNA8jyDvakb7A3TN9C2SxMoOuP4806wPR5CleSnooVnhAdwjLPzroGvptOgd5Y 04cdvVgwiueJha10/lEF3hqV0N0Dh14Al8iAEPSgZ5yp6CiQ1P7bOq8o5WU+XaOF013h REq93yocWRxSML6fSrl++tRkYZJgk1XJQA/k/kyjQ6UWsnOvFl4zEixziUjhKayjb3fV LTRJiU/rvFWPloRNBxQn8gU+0iU6dTfkxLhYUEBPg3GHeOVWCfQ9249LcA6Wt7n1+sBR vZAg== X-Gm-Message-State: AFqh2kpy9FtigD0WMOraISF+CZG2k5oqUUw3vbCGO8wZ0aqVSvWtt0xD EcmOUuGnOu1wcXHaTIRd9HE= X-Google-Smtp-Source: AMrXdXutyIj0FqnvgBJceXUgRJWFSVhcqW5yaLmlcMMfHbId3Go5+IXOGwElDInV/ls+8h3cPoxvwA== X-Received: by 2002:a05:600c:538c:b0:3cf:6f4d:c259 with SMTP id hg12-20020a05600c538c00b003cf6f4dc259mr44248wmb.39.1673886629656; Mon, 16 Jan 2023 08:30:29 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n6-20020adfe786000000b002bdbde1d3absm16554529wrm.78.2023.01.16.08.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 08:30:29 -0800 (PST) Content-Language: en-US In-Reply-To: <87wn5mkjqk.fsf@thornhill.no> Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.097, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302461 Archived-At: On 16/01/2023 09:43, Theodor Thornhill wrote: > Dmitry Gutov writes: > >> On 15/01/2023 16:01, Eli Zaretskii wrote: >>> You will >>> see that where possible, just loading a TS mode modifies >>> auto-mode-alist if the tree-sitter support for that mode is available, >>> whereas for other modes auto-mode-alist is modified only when the mode >>> is actually turned on successfully for the first time. This is >>> because some of the TS modes have their own *.el files, whereas others >>> share a .el file with other modes, and so loading that file doesn't >>> necessarily means the user wants to use the tree-sitter based mode. >> If we*are* going to do this (make all ts mode strictly optional), I >> don't think either of this is a good idea: for a given foo-ts-mode, the >> user might already have an auto-mode-alist entry configured with another >> mode (third-party or not), and they will likely 'M-x foo-ts-mode' to try >> how well it works (or doesn't). >> >> Having auto-mode-alist modified automatically can come as a surprise >> either way. >> >> Note the this is different to having the auto-mode-alist entries set up >> from the outset, because the user's alterations override those. >> >> We can drop the auto-mode-alist alterations from ts modes altogether, to >> bring them back when we do decide to enable them by default. > I'm fine with either, but I understood your proposal to just remove all > the auto-mode-alist additions for emacs-29, then let users config that > themselves. My preferred course of action was to keep things as-is, but since that's not in the cards, the proposed alternative for emacs-29 was to indeed remove the auto-mode-alist additions entirely, to keep things simple.