[PATCH] MH-E: don't automatically download external-body parts

[PATCH] MH-E: don't automatically download external-body parts

[Mike Kupfer]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Is the attached okay for emacs-26, or should it go to master?  It makes
MH-E behave more like Gnus when displaying a message that has a MIME
external-body part.

regards,
mike


[-- Attachment #2: git formatted patch --]
[-- Type: text/plain, Size: 1508 bytes --]

From 4c8fcd7115c7eb6203f8bce0e2787d7fd2a08929 Mon Sep 17 00:00:00 2001
From: Mike Kupfer <mkupfer@alum.berkeley.edu>
Date: Sat, 18 Nov 2017 16:49:10 -0800
Subject: [PATCH] MH-E: don't automatically download external-body parts

* lisp/mh-e/mh-mime.el (mh-mime-display-single): Use
mm-automatic-display-p to verify that a part should be
displayed before doing the inline checks (SF#475).
---
 lisp/mh-e/mh-mime.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/mh-e/mh-mime.el b/lisp/mh-e/mh-mime.el
index 9d1edf0..69c57e0 100644
--- a/lisp/mh-e/mh-mime.el
+++ b/lisp/mh-e/mh-mime.el
@@ -659,6 +659,7 @@ mh-mime-display-single
          (attachmentp (equal (car (mm-handle-disposition handle))
                              "attachment"))
          (inlinep (and (equal (car (mm-handle-disposition handle)) "inline")
+                       (mm-automatic-display-p handle)
                        (mm-inlinable-p handle)
                        (mm-inlined-p handle)))
          (displayp (or inlinep                   ; show if inline OR
@@ -669,6 +670,7 @@ mh-mime-display-single
                                 (and (not (equal
                                            (mm-handle-media-supertype handle)
                                            "image"))
+                                     (mm-automatic-display-p handle)
                                      (mm-inlinable-p handle)
                                      (mm-inlined-p handle)))))))
     (save-restriction
-- 
2.1.4

Re: [PATCH] MH-E: don't automatically download external-body parts

[Eli Zaretskii]

> From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> Date: Sat, 18 Nov 2017 16:58:18 -0800
> 
> Is the attached okay for emacs-26, or should it go to master?  It makes
> MH-E behave more like Gnus when displaying a message that has a MIME
> external-body part.

Can you please point me to the description of the problem this tries
to solve?

Also, what branch of the MH-E repository will this be committed to?

Re: [PATCH] MH-E: don't automatically download external-body parts

[Mike Kupfer]

Eli Zaretskii wrote:

> Can you please point me to the description of the problem this tries
> to solve?

The relevant bug report is at

  https://sourceforge.net/p/mh-e/bugs/475/

In short, the problem is that if you view a message that contains an
external-body part, MH-E will immediately start downloading it, whether
the user wanted that or not.  With this fix, the user initiates the
download by clicking on the button for the external-body part.

(Sorry, I should have included more details in my original message.)

> Also, what branch of the MH-E repository will this be committed to?

I'm not sure I understand the question.  MH-E has a separate repository
for its tests and old XEmacs support, but the primary codebase is in the
main Emacs git repository.

The bug is annoying (and a privacy leak), with a simple fix that only
touches MH-E, so I'd like to push it to emacs-26, but if you'd rather
that it go to master, I'll do that instead.

thanks,
mike

Re: [PATCH] MH-E: don't automatically download external-body parts

[Eli Zaretskii]

> From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> cc: emacs-devel@gnu.org
> Date: Sun, 19 Nov 2017 08:07:21 -0800
> 
> Eli Zaretskii wrote:
> 
> > Can you please point me to the description of the problem this tries
> > to solve?
> 
> The relevant bug report is at
> 
>   https://sourceforge.net/p/mh-e/bugs/475/
> 
> In short, the problem is that if you view a message that contains an
> external-body part, MH-E will immediately start downloading it, whether
> the user wanted that or not.  With this fix, the user initiates the
> download by clicking on the button for the external-body part.

Thanks, this is good for emacs-26.