From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: maphash Date: Wed, 2 Oct 2024 10:43:52 +0200 Message-ID: <88481AA6-D70B-4851-9CD8-337A9740F189@gmail.com> References: <875xr3h5g9.fsf@gmail.com> <86wmiw6ueu.fsf@gnu.org> <42AF49E0-6085-48E8-B3FE-706E97457E06@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22446"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Helmut Eller , emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 02 10:44:52 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svuya-0005k8-4f for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Oct 2024 10:44:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svuxn-0008SP-09; Wed, 02 Oct 2024 04:44:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svuxk-0008S8-Mq for emacs-devel@gnu.org; Wed, 02 Oct 2024 04:44:00 -0400 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svuxj-0006Di-9S; Wed, 02 Oct 2024 04:44:00 -0400 Original-Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2fada911953so6081271fa.0; Wed, 02 Oct 2024 01:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727858636; x=1728463436; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=OYey1iAi10Ubj4v+CJr1gHL9YoYTNiE1zzVuJh2AJvE=; b=B7sL3/piBd3hTi+mrfw3h6SrEOSQ6y0/yDsQo6BqyZwJQojEiqU0bqVwCsE+rQ14Yw a1YMMz7tdHNfGzzjHkp4PjEQvQw1xkmTLbWWNZXa3iK0fbVrVW/7UF3Vnjz0zjQ/J5lS YAdCFd/PIrCC8TEVI78tjjyvf6oPotJWEtloDr3U5UlK1xfHb+xWuhOYCSUlBqt7ipcD ZvLuazLgX6OBfNs3VAN2ZFPQuEyHjIIIo0FV9mzES9wJkspjMbNnGuBZOOhZwEqVwIAg IHJuXZ9HdOzmnImDZI3ZblRo4mSy4HKMLPttYznd6LcjPYn4ZUEAxZpkt9jrN6adc444 2tCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727858636; x=1728463436; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OYey1iAi10Ubj4v+CJr1gHL9YoYTNiE1zzVuJh2AJvE=; b=BXV1ZGtucaNFG5a2xqufEr6FPxW2h9S5+EgZkxZ4F1D1j7XyZU5yp+d9ih87ZosG0C iPZSEieewq3SSWfTNc6BKDK5Zo/PBNuSlrMmpASzvX1/e62rH3OMbzcnJPmLcEpPnPLT xzFHGnm6q5UxXxWp/e3ryxCuR8qQLdHWbOmv/RLjT/Cv+SbKnM7ZwS0iKoW6LSmYyvuR KO6UDnqjYSyftS9tZBEekCqqkVTM+hEK6YnR+cdHwRiK8lgW49Ui25YqTIEmccyXJwr8 BWjm/qPohjmPxSgl6OX7GcHEUzqelcfF1Gqv77w0brYuwcX+9a29Nt7hreU7BLp50jtS dxoQ== X-Forwarded-Encrypted: i=1; AJvYcCWZYRPlFP4N1FxjtHJJ5iWRYpQ2HfvOTY7O25iTyYFWoezqvJU5nQMvnOfZc9SsoLFPF3nc+R2ER12XFQ==@gnu.org X-Gm-Message-State: AOJu0YycNyinMOjscP681BgtXwUhFtA+RjD+xUM6GLsq4+ykN+2dunpN y7mQQ98S1wRZldml8hOA10TWr0GPpnwwd0sPV0SfJJYNBjftI6UnHSeR2g== X-Google-Smtp-Source: AGHT+IET+VXrsiw3Tuo3W04eLdWEtHJSGtJaxxOQy7scJrHQorowCEjG9ESegZ/vxMfwKNGHYzW9jg== X-Received: by 2002:a05:6512:280c:b0:52c:ebf6:9a87 with SMTP id 2adb3069b0e04-539a0176a70mr752756e87.26.1727858636221; Wed, 02 Oct 2024 01:43:56 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5398eaec891sm1352785e87.240.2024.10.02.01.43.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Oct 2024 01:43:55 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324243 Archived-At: 1 okt. 2024 kl. 20.36 skrev Andrea Corallo : >> Would you also take a look at the four DOHASH_SAFE uses in >> comp.c, and see if there is any possibility of mutation of the tables >> iterated over? Then they could be changed to DOHASH. >=20 > Thanks I think the use of DOHASH_SAFE is correct there. Mind explaining why? Note that DOHASH does attempt to catch some table = mutations when checking is enabled. DOHASH_SAFE is intended for Fmapcar, where there may be mutations and we = mustn't crash because of them but we don't care about semantics in that = case.