From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Mon, 26 Jul 2021 13:09:13 -0400 Message-ID: <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> References: <83h7gw6pyj.fsf@gnu.org> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14006"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, Stephen Leake , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 26 19:09:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8473-0003P1-Tu for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Jul 2021 19:09:57 +0200 Original-Received: from localhost ([::1]:49628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8472-0005rF-Vp for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Jul 2021 13:09:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m846Q-0005Bh-OR for emacs-devel@gnu.org; Mon, 26 Jul 2021 13:09:18 -0400 Original-Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:45773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m846O-0003X8-CW; Mon, 26 Jul 2021 13:09:18 -0400 Original-Received: by mail-qk1-x736.google.com with SMTP id 190so9500022qkk.12; Mon, 26 Jul 2021 10:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=GELkoh4zXT2dyBPDGAs+ZmAtg6fmVpCaL34VK1pjt8w=; b=HTbLztJMAkqIJPoc/8nGebQ7y/B1YntdoaTgwYvGqL/MRRQRGsCCf/SgWDA6O8i8mp bByPEqgMYUli6DJoSetvuO8PevpqILgYV2igU5v5b2axF2nQD1qq1WdjZH6krQvBw4AC k6YnIptApU8QYIDfVnhuqetk5A6DF79dWHOLqVkXeA0kRKsVPBlDtPoectgQfceVbZeN Vd/8/W1v6FMbReIyVK4RtuLoXQG8SE1ndvZ1pMUSGg+8JU0mxf2HGbvZoOrQyGVtvCvD KUzy7/vftWv19xNrq32Z+oPPSE0BoY2fRSX3q0Gz1ibat6HWaJfCdI6IGbMS91Smx2GT dmlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=GELkoh4zXT2dyBPDGAs+ZmAtg6fmVpCaL34VK1pjt8w=; b=hhy7aXbrk1uSIKQvS498/P7mZ0wDb8LJ2EQBifs/+p4yQ6KQl4KKYw+lEm6Fzbpqnk 2un1oRXvjlSc7qXiHrl+ONhbAL7nJvCfGNVh/lhelUVpTZjay4OvjzkVt6J5iH1YSsyd LrH44GFAH/xGshNwKuTja2k8VCj+rDetUsM9b4JVTrKUgMXPobZXOfDFnbV9wH0t8OVQ Y9hWVssUne6KLQABD81QfyEhA2AHnbpoZgrF9rbxo+AbcQO1/wY410dzyi8lFkY+FB1I 8wH4TWOJNN9Ku3CdB6JYgYaj44ZNg7NSZYT+rJYoDvgIfudd670Vc/+cV3Nmn3kwlU7C STrA== X-Gm-Message-State: AOAM533jBN53+9TDC6QqxJWk/T3YDN0d4mccwGKr7okeEr1JlZJsCpSN 4JGWhJQrEu2iCONVqbnzJ8WO2f7j+AqGmQ== X-Google-Smtp-Source: ABdhPJxqj34t8t1OUrRbA037dekzlFl5z9kJIbMOAoVA9+fLbSeYNUJxbOwoY0ewiMJ9kPGKb2vxNA== X-Received: by 2002:a37:c12:: with SMTP id 18mr17955491qkm.414.1627319354708; Mon, 26 Jul 2021 10:09:14 -0700 (PDT) Original-Received: from 2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com (2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com. [2603:7080:302:635e:540d:2222:3fe9:1314]) by smtp.gmail.com with ESMTPSA id c6sm290524qke.133.2021.07.26.10.09.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jul 2021 10:09:14 -0700 (PDT) In-Reply-To: <83r1fluikh.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::736; envelope-from=casouri@gmail.com; helo=mail-qk1-x736.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271655 Archived-At: >>=20 >>> Once again, we are talking about the function used by TS to read >>> buffer text. Not about the parser or its caller. Low-level code, >>> which knows nothing about the context, should never look beyond the >>> restriction. >>=20 >> It doesn=E2=80=99t harm for tree-sitter to see the rest of the = buffer, it doesn=E2=80=99t modify anything, all it does it reading the = text. OTOH, restricting tree-sitter to the bounds of narrows adds = complexity for no benefit (as far as I can see). >=20 > Which complexity does it add? You just compare with BEGV_BYTE instead > of BEG_BYTE etc. We need to =E2=80=9Cdelete=E2=80=9D the hidden text and =E2=80=9Cre-insert= =E2=80=9D when we widen the buffer. I=E2=80=99ll try to make it a no-op = as long as we remember to widen before calling tree-sitter to parse = anything. >=20 > If we let TS look where it wants, we will lose the ability to restrict > it to a certain part of the buffer text. This is needed at least for > some specialized modes, and is generally desirable, as it gives Lisp > programs an easy way to impose such restrictions whenever they need. Tree-sitter lets you set ranges for a parser to limit it self within, in = order to support multi-language files. >=20 >> Maybe narrowing is the context that low level code should ignore >=20 > No other code in Emacs does, and for a good reason. >=20 >> The only benefit that I can think of is =E2=80=9Cwe firmly adhere to = the =E2=80=98contract=E2=80=99 that no one can look beyond the narrowed = region=E2=80=9D, but is it a good contract? Is there really a contract = in the first place? >=20 > It served us very well until now, so yes, I think it's a good > contract. >=20 >> IMO, narrowing acts like masking tapes over the rest of the buffer, = so that user edits like re-replace wouldn=E2=80=99t spill out. Demanding = everything in Emacs to not have access to the rest of the buffer is = dogmatic (in the sense that it is too rigid and is simply following the = doctrine blindly).=20 >=20 > Again, this "dogma" is used and adhered everywhere else in Emacs by > such low-level code. Ok. I trust you to know better than I do. Yuan=