From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: desktop.el and minor modes Date: Mon, 07 Jun 2004 11:09:45 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87zn7fbxh2.fsf@mail.jurta.org> References: <40C209EE.2020204@math.ku.dk> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1086597647 27869 80.91.224.253 (7 Jun 2004 08:40:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 7 Jun 2004 08:40:47 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jun 07 10:40:38 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BXFgM-0004BV-00 for ; Mon, 07 Jun 2004 10:40:38 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BXFgM-0000mD-00 for ; Mon, 07 Jun 2004 10:40:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BXFgs-000523-U0 for emacs-devel@quimby.gnus.org; Mon, 07 Jun 2004 04:41:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BXFgq-000519-AM for emacs-devel@gnu.org; Mon, 07 Jun 2004 04:41:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BXFgo-00050l-La for emacs-devel@gnu.org; Mon, 07 Jun 2004 04:41:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BXFgo-00050T-Hj for emacs-devel@gnu.org; Mon, 07 Jun 2004 04:41:06 -0400 Original-Received: from [66.33.219.19] (helo=spoon.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BXFfs-00066t-7D for emacs-devel@gnu.org; Mon, 07 Jun 2004 04:40:08 -0400 Original-Received: from mail.jurta.org (80-235-35-47-dsl.mus.estpak.ee [80.235.35.47]) by spoon.dreamhost.com (Postfix) with ESMTP id 252B613D8C4; Mon, 7 Jun 2004 01:40:06 -0700 (PDT) Original-To: Lars Hansen User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24649 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24649 Lars Hansen writes: > Anyway, I just installed it (modified to bind dired-mark-omitted to > M-O) together with and update of dired-x.texi. I tried your changes, and `dired-omit-mode' works well, as expected. Thanks. However, this change is not backward compatible. I can't tell how serious this problem is, but users who have the old variable `dired-omit-files-p' customized in their .emacs may discover that it doesn't work anymore. The reason is that old `dired-omit-files-p' was a global variable defined by defcustom, but `dired-omit-mode' is a minor mode defined without `:global t' argument. One solution is to add `:global t' to make `dired-omit-mode' customizable (`define-minor-mode' interprets `:global t' by defining it by `defcustom'). But this requires adding a special call to `make-variable-buffer-local' to make customizable `dired-omit-mode' buffer-local that may cause problems for desktop.el where the variable `dired-omit-mode' will be saved for all buffers. So until a good solution is found, you can simply write an appropriate entry to etc/NEWS with explanations that instead of customizing `dired-omit-files-p' users should write a call to `dired-omit-mode' in the dired mode hook. -- Juri Linkov http://www.jurta.org/emacs/