From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.devel Subject: Re: generic-x needs to require generic Date: Tue, 22 Mar 2005 09:22:26 +0100 Message-ID: <87zmwwgke5.fsf@xs4all.nl> References: <200503212107.j2LL7g226633@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1111479850 12262 80.91.229.2 (22 Mar 2005 08:24:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 22 Mar 2005 08:24:10 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 22 09:24:09 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DDegD-0001wM-PI for ged-emacs-devel@m.gmane.org; Tue, 22 Mar 2005 09:24:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DDexT-0006l1-M9 for ged-emacs-devel@m.gmane.org; Tue, 22 Mar 2005 03:41:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DDevg-0006Ez-6q for emacs-devel@gnu.org; Tue, 22 Mar 2005 03:40:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DDevc-0006Ce-I1 for emacs-devel@gnu.org; Tue, 22 Mar 2005 03:39:58 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DDevb-0006Bw-Bl for emacs-devel@gnu.org; Tue, 22 Mar 2005 03:39:55 -0500 Original-Received: from [194.109.24.30] (helo=smtp-vbr10.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DDeeo-0005iU-36 for emacs-devel@gnu.org; Tue, 22 Mar 2005 03:22:34 -0500 Original-Received: from pijl (a80-127-67-124.adsl.xs4all.nl [80.127.67.124]) by smtp-vbr10.xs4all.nl (8.12.11/8.12.11) with ESMTP id j2M8MQfG071905; Tue, 22 Mar 2005 09:22:27 +0100 (CET) (envelope-from Lute.Kamstra@xs4all.nl) Original-Received: from lute by pijl with local (Exim 3.36 #1 (Debian)) id 1DDeeg-0002e3-00; Tue, 22 Mar 2005 09:22:26 +0100 Original-To: Luc Teirlinck In-Reply-To: <200503212107.j2LL7g226633@raven.dms.auburn.edu> (Luc Teirlinck's message of "Mon, 21 Mar 2005 15:07:42 -0600 (CST)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Original-Lines: 31 X-Virus-Scanned: by XS4ALL Virus Scanner X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34948 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34948 Luc Teirlinck writes: > What is the purpose of the following change to generic-x, which breaks > bootstrapping: > > * generic-x.el: Don't prevent compilation. Don't require generic. > Follow coding conventions. Minor code cleanup. > > I am referring to the "Don't require generic." part. Undoing that > part solves the following problem during bootstrapping: The function generic-make-keywords-list that is called in generic-x is defined in generic. So it should probably be autoloaded. Alternatively generic-x could (eval-when-compile (require 'generic)) and (eval-when-compile ...) all calls to generic-make-keywords-list as well. I missed this because bootstrapping my working-tree worked just fine. I also did an update for another tree without the generic{,-x}.el patches and it bootstrapped fine. A clean checkout fails to bootstraps however. This is quite strange. I guess that for me the define-generic-mode calls in generic-x that precede the generic-make-keywords-list call autoload generic so that generic is loaded when the call to generic-make-keywords-list is compiled. Why this doesn't happen for you of for a clean checkout beats me. I'll put (require 'generic) back in for now to enable bootstrapping. Lute.