From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Jesper Harder <harder@phys.au.dk>
Newsgroups: gmane.emacs.devel
Subject: Re: Suspicious code in gnus-read-descriptions-file
Date: Thu, 24 Mar 2005 15:07:01 +0100
Organization: http://purl.org/harder/
Message-ID: <87zmwtqgsa.fsf@Jesper-Harders-Computer.local>
References: <jwvzmwvo6sb.fsf-monnier+emacs@gnu.org>
	<87eke71cnj.fsf@Jesper-Harders-Computer.local>
	<m1br9aplv6.fsf-monnier+emacs@gnu.org>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1111673778 16619 80.91.229.2 (24 Mar 2005 14:16:18 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Thu, 24 Mar 2005 14:16:18 +0000 (UTC)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 24 15:16:17 2005
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1DET7x-0004qP-Qg
	for ged-emacs-devel@m.gmane.org; Thu, 24 Mar 2005 15:16:02 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1DETNF-0001Vd-VP
	for ged-emacs-devel@m.gmane.org; Thu, 24 Mar 2005 09:31:49 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DETL2-0000oe-Kc
	for emacs-devel@gnu.org; Thu, 24 Mar 2005 09:29:35 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DETKx-0000lj-4A
	for emacs-devel@gnu.org; Thu, 24 Mar 2005 09:29:28 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DETKv-0000cR-2D
	for emacs-devel@gnu.org; Thu, 24 Mar 2005 09:29:25 -0500
Original-Received: from [212.247.154.161] (helo=swip.net)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DESzW-0004zv-So
	for emacs-devel@gnu.org; Thu, 24 Mar 2005 09:07:19 -0500
X-T2-Posting-ID: 6v7UXmte3bqfgw4oLiS+UA==
Original-Received: from [83.72.212.87] (HELO Jesper-Harders-Computer.local)
	by mailfe06.swip.net (CommuniGate Pro SMTP 4.2.9)
	with ESMTP id 316743668 for emacs-devel@gnu.org;
	Thu, 24 Mar 2005 15:07:11 +0100
Original-To: emacs-devel@gnu.org
X-Face: ^RrvqCr7c,P$zTR:QED"@h9+BTm-"fjZJJ-3=OU7.)i/K]<.J88}s>'Z_$r;
	<N5ksn~%wJ@2pjF}="tV; FBsdpFarSWA<oYkZsViGf:F^SD-KXhvFxh;
	~]?)SWm~+u}; 0=x}<vOm&5J+?]yB2d]q4x8\0g7SX
Mail-Copies-To: never
In-Reply-To: <m1br9aplv6.fsf-monnier+emacs@gnu.org> (Stefan's message of "Wed, 
	23 Mar 2005 07:53:32 -0500")
User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (darwin)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
X-MailScanner-To: ged-emacs-devel@m.gmane.org
Xref: news.gmane.org gmane.emacs.devel:35096
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35096

Stefan <monnier@iro.umontreal.ca> writes:

>> But if point /is/ changed, I've often found it pretty hard to be
>> absolutely sure if saving point is actually intended and required.
>
> There's indeed the possibility that the code is usually called with
> nntp-server-buffer already the current buffer and point in
> nntp-server-buffer needs to be saved.

Yup, that's what I was thinking about.  I think I've encountered a few
places like that.  

It's probably not an issue in your changes ... but it's something you
should have in mind when making this type of change.