From: Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>
Cc: "Richard M. Stallman" <rms@gnu.org>, emacs-devel@gnu.org
Subject: Re: debug declaration.
Date: Wed, 30 Mar 2005 10:12:42 +0200 [thread overview]
Message-ID: <87zmwlsgat.fsf@xs4all.nl> (raw)
In-Reply-To: <m1is3fvkis.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 25 Mar 2005 10:14:38 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
[...]
>>> Another option is to evaluate those arguments before you plug them
>>> in the body of your major mode function, so they're only evaluated
>>> once, when the major mode is defined, thus reproducing the
>>> "pre-macro" behavior.
>
>> Considering backward compatibility, that's probably the right thing
>> to do.
>
> It also moves more work to macro-expansion time which is good. But
> beware, it can also break backward compatibility, because now
> evaluation can take place at byte-compile time.
>
> OTOH it's closer to what I meant by "turn it into a macro" (in the
> comment that prompted you to look into this whole thing). Ideally
> define-generic-mode should (just like define-derived-mode does)
> generate stand-alone code which does not require generic.el.
I considered this when I started to work on generic.el, but moving all
the code into define-generic-mode would lead to some code duplication.
Especially generic-mode-set-comments is a bit long.
The body of generic-mode-internal could be moved to
define-generic-mode as it is short. This would also make the code
clearer, IMO. If define-generic-mode would then evaluate its argument
COMMENT-LIST during macro expansion, it could generate stand-alone
code if COMMENT-LIST is nil.
Maybe it's a good thing if define-generic-mode evaluated all it's
arguments during macro expansion. For all the examples in
generic-x.el at least, it didn't matter if the arguments were
evaluated during compilation or during the loading of generic-x.elc.
Actually, I made all the arguments of calls to define-generic-mode
either constant or I eval-when-compile'd them to speed up the loading
of generic-x.elc.
Lute.
next prev parent reply other threads:[~2005-03-30 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 15:54 debug declaration Lute Kamstra
2005-03-23 18:18 ` Stefan Monnier
2005-03-25 11:06 ` Lute Kamstra
2005-03-25 15:14 ` Stefan Monnier
2005-03-27 3:52 ` Richard Stallman
2005-03-30 8:12 ` Lute Kamstra [this message]
2005-03-31 18:21 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmwlsgat.fsf@xs4all.nl \
--to=lute.kamstra.lists@xs4all.nl \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).