From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: completing-read (and M-x) with pop-up-frames non-nil changes frame focus
Date: Fri, 15 Jul 2005 03:35:34 -0400 [thread overview]
Message-ID: <87zmsoh6a8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87r7e0iqwh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 15 Jul 2005 01:27:08 -0400")
> So maybe Fdisplay_buffer should protect against it with something like the
> patch below. Does it help?
Sorry about the botched patch. Try this one instead,
Stefan
--- window.c 13 jui 2005 13:58:39 -0400 1.512
+++ window.c 15 jui 2005 03:30:07 -0400
@@ -3475,7 +3475,13 @@
we need to create a new frame. */
if (pop_up_frames || last_nonminibuf_frame == 0)
{
+ Lisp_Object w = Fselected_window ();
+ struct gcpro gcpro1;
+ GCPRO1 (w);
window = Fframe_selected_window (call0 (Vpop_up_frame_function));
+ if (Fwindow_live_p (w))
+ Fselect_window (w, Qt);
+ UNGCPRO;
Fset_window_buffer (window, buffer, Qnil);
return display_buffer_1 (window);
}
next prev parent reply other threads:[~2005-07-15 7:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-15 3:35 completing-read (and M-x) with pop-up-frames non-nil changes frame focus Drew Adams
2005-07-15 5:27 ` Stefan Monnier
2005-07-15 7:35 ` Stefan Monnier [this message]
2005-07-15 14:07 ` Drew Adams
2005-07-15 20:45 ` Stefan Monnier
2005-07-15 20:55 ` Drew Adams
2005-07-18 4:48 ` Richard M. Stallman
2005-07-18 5:10 ` completing-read (and M-x) with pop-up-frames non-nil changes framefocus Drew Adams
2005-07-18 21:23 ` Richard M. Stallman
2005-07-18 22:14 ` completing-read (and M-x) with pop-up-frames non-nil changesframefocus Drew Adams
2005-07-19 20:32 ` Richard M. Stallman
2005-07-19 21:04 ` completing-read (and M-x) with pop-up-frames non-nilchangesframefocus Drew Adams
2005-07-20 22:09 ` Richard M. Stallman
2005-07-20 22:51 ` Henrik Enberg
2005-07-20 22:57 ` Jan D.
2005-07-20 23:19 ` completing-read (and M-x) with pop-up-framesnon-nilchangesframefocus Drew Adams
2005-07-21 17:08 ` Richard M. Stallman
2005-07-21 18:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmsoh6a8.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).