From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Slow Info startup Date: Fri, 02 Dec 2005 02:03:23 +0200 Organization: JURTA Message-ID: <87zmnkcqk8.fsf@jurta.org> References: <878xv6zwqa.fsf@stupidchicken.com> <878xv4h4l1.fsf@jurta.org> <87iru8wi3v.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1133482542 2537 80.91.229.2 (2 Dec 2005 00:15:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2005 00:15:42 +0000 (UTC) Cc: yamaoka@jpl.org, rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 02 01:15:40 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EhyYe-0006Ev-21 for ged-emacs-devel@m.gmane.org; Fri, 02 Dec 2005 01:13:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EhyYa-0004XN-0D for ged-emacs-devel@m.gmane.org; Thu, 01 Dec 2005 19:13:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EhySp-0001ju-W0 for emacs-devel@gnu.org; Thu, 01 Dec 2005 19:07:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EhySi-0001e0-TE for emacs-devel@gnu.org; Thu, 01 Dec 2005 19:07:45 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EhySi-0001dX-81 for emacs-devel@gnu.org; Thu, 01 Dec 2005 19:07:40 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EhySW-0000oN-Jf; Thu, 01 Dec 2005 19:07:29 -0500 Original-Received: from mail.neti.ee (80-235-43-77-dsl.mus.estpak.ee [80.235.43.77]) by Relayhost1.neti.ee (Postfix) with ESMTP id CD8011712; Fri, 2 Dec 2005 02:07:34 +0200 (EET) Original-To: Chong Yidong In-Reply-To: <87iru8wi3v.fsf@stupidchicken.com> (Chong Yidong's message of "Thu, 01 Dec 2005 17:46:44 -0500") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46864 Archived-At: > Actually, we only need to use file-name-nondirectory for Info node > names specifying other info files. This way, links within info files > will always be highlighted correctly, even for info session started > with Info-on-current-buffer (external links will still have the flaw > discussed previously). > [...] > ! (external-link-p > ! (string-match "(\\([^)]+\\))\\([^)]*\\)" node)) > ! (file (if external-link-p > ! (match-string 1 node) You need `file-name-nondirectory' around `match-string' here (and in another similar place below). But generally your patch should work correctly for links in the same Info file, so I think it is a good improvement. (And I'd prefer one loop with `if external-link-p' inside for clarity, because two separate loops wouldn't get significant speedup here). -- Juri Linkov http://www.jurta.org/emacs/